HTML API: Prevent incorrect newline injection in non-html TEXTAREA, etc.#12322
HTML API: Prevent incorrect newline injection in non-html TEXTAREA, etc.#12322sirreal wants to merge 11 commits into
Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
HTML and foreign element normalization differ in some cases. Ensure the HTML-specific newline injection is not applied to foreign elements like `svg:textarea`. Developed in #12322. Follow-up to [61747]. See #65372. git-svn-id: https://develop.svn.wordpress.org/trunk@62574 602fd350-edb4-49c9-b593-d223f7449a82
|
Committed in r62574. |
HTML and foreign element normalization differ in some cases. Ensure the HTML-specific newline injection is not applied to foreign elements like `svg:textarea`. Developed in WordPress/wordpress-develop#12322. Follow-up to [61747]. See #65372. Built from https://develop.svn.wordpress.org/trunk@62574 git-svn-id: http://core.svn.wordpress.org/trunk@61854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
HTML and foreign element normalization differ in some cases. Ensure the HTML-specific newline injection is not applied to foreign elements like `svg:textarea`. Developed in WordPress#12322. Follow-up to [61747]. See #65372. git-svn-id: https://develop.svn.wordpress.org/trunk@62574 602fd350-edb4-49c9-b593-d223f7449a82
HTML and foreign element normalization differ in some cases. Ensure the HTML-specific newline injection is not applied to foreign elements like `svg:textarea`. Developed in WordPress#12322. Follow-up to [61747]. See #65372. git-svn-id: https://develop.svn.wordpress.org/trunk@62574 602fd350-edb4-49c9-b593-d223f7449a82
HTML
PRE,LISTING, andTEXTAREAelements ignore a leading newline. Previous changes ensured those newline were preserved on normalization (r61747), but did not account for non-HTML examples of these elements (for examplesvg:textarea).Ensure the newlines are not incorrectly added to analogous non-HTML elements. Currently, successive normalizations of the following produce:
<svg><textarea>X<svg><textarea>\nX</textarea></svg><svg><textarea>\n\nX</textarea></svg>Trac ticket: https://core.trac.wordpress.org/ticket/65372
Follow-up to r61747
Use of AI Tools
AI assistance: Yes
Tool(s): Codex GPT-5.5
Used for: Fuzz testing, diagnosis, initial fix implementation, review and feedback.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.