Clarify and regularize text format index parsing rules#655
Open
lukewagner wants to merge 2 commits into
Open
Conversation
bvisness
reviewed
May 19, 2026
alexcrichton
approved these changes
May 23, 2026
lukewagner
force-pushed
the
tweak-id-syntax
branch
from
c16b074 to
c86bb48
Compare
lukewagner
force-pushed
the
tweak-id-syntax
branch
from
c86bb48 to
4302859
Compare
lukewagner
force-pushed
the
tweak-id-syntax
branch
from
4302859 to
757080b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to resolve #648 by regularizing and more-clearly defining the text format rules for core- and component-level indices, identifiers and inline aliases. One nice thing with the changes in this PR is that there is now an explicit
core-prefix(...)in the grammar at all the places wherecoremight (when a plain$idis not used) get injected.The
test/syntax/indices.wasttries to test all the syntactic cases touched by this PR. The commented-out lines currently fail inwasm-toolsand the rest pass as-is. This helps identify what the concrete delta from the status quo is. I didn't add any negative tests since I expect we'll need a phase-out process before rejecting anything that is accepted now.PTAL @bvisness @alexcrichton