inplace_iterator: Add enough iteration to support std::erase_if#8877
Conversation
| } // namespace detail | ||
|
|
||
| template<typename Vector, typename Pred> | ||
| requires detail::is_inplace_vector_or_derived<Vector>::value |
There was a problem hiding this comment.
I think we're still hiding use of requires behind ifdefs so jukka's old system compilers still work... but if we're not testing that on CI, maybe we shouldn't worry about that beyond letting him fix things up as necessary.
There was a problem hiding this comment.
Hmm, I see the lattice code has such ifdefs, but we have other requires without? E.g.
binaryen/src/wasm-type-printing.h
Line 119 in 82b8645
There was a problem hiding this comment.
Landing, if there is an issue later I can fix it up.
|
|
||
| } // namespace wasm | ||
|
|
||
| namespace std { |
There was a problem hiding this comment.
Kind of weird that you have to provide a new overload of a std function to support custom containers, but it looks like this is the standard practice?
There was a problem hiding this comment.
Yeah, I don't know how else to do this. The compiler errors without these overloads.
2 participants
erase_if will be needed in a later PR.