Skip to content

feat(dart): add dart config to very_good.yaml#1664

Merged
marcossevilla merged 5 commits into
mainfrom
vgv-ai-bot/issue-1655
Jul 27, 2026
Merged

feat(dart): add dart config to very_good.yaml#1664
marcossevilla merged 5 commits into
mainfrom
vgv-ai-bot/issue-1655

Conversation

@unicoderbot

@unicoderbot unicoderbot Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Add support for VeryGoodDartConfig configuration in the very_good.yaml file to customize defaults for the very_good dart test command.

Changes

  • Added VeryGoodDartConfig and VeryGoodDartTestConfig classes to support dart-specific configuration
  • Updated DartTestCommand.run() to load and apply configuration from very_good.yaml
  • Modified DartTestOptions.parse() to accept a VeryGoodConfig parameter and resolve argument values with proper precedence: CLI args > config values > CLI defaults
  • Added _resolveArg() helper function to handle argument resolution with fallback values
  • Updated error handling to catch and report VeryGoodConfigParseException
  • Added comprehensive tests for configuration parsing and precedence
  • Updated documentation with dart test configuration examples

Configuration Precedence

Argument values are resolved in the following order:

  1. Command line arguments (highest priority)
  2. Values from very_good.yaml configuration
  3. CLI default values (lowest priority)

Closes #1655

Closes #1655

Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
@unicoderbot
unicoderbot Bot requested a review from a team as a code owner July 27, 2026 10:58
ryzizub
ryzizub previously approved these changes Jul 27, 2026

@ryzizub ryzizub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcossevilla

Copy link
Copy Markdown
Member

@vgvbot merge main into this PR, solve the conflicts that come up

@unicoderbot

unicoderbot Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

On it, I'll merge the target branch into this PR and resolve any conflicts.

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Fetching target branch
  • Merging target into PR
  • Updating PR branch

I merged main into this PR and resolved the conflicts.

Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
@marcossevilla
marcossevilla merged commit 694478a into main Jul 27, 2026
24 checks passed
@marcossevilla
marcossevilla deleted the vgv-ai-bot/issue-1655 branch July 27, 2026 15:39
@vgvbot vgvbot mentioned this pull request Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(dart): add dart config to very_good.yaml

2 participants