fix: prevent framework documentation page from freezing on link hover#1010
Open
Manishkumarbingi wants to merge 1 commit into
Open
fix: prevent framework documentation page from freezing on link hover#1010Manishkumarbingi wants to merge 1 commit into
Manishkumarbingi wants to merge 1 commit into
Conversation
…ing the page on hover
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo links in the framework card now explicitly disable route preloading. ChangesFrameworkCard link preload behavior
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change disables route preloading for the framework documentation links rendered by
FrameworkCard.Background
The framework documentation page currently becomes unresponsive when hovering the framework cards (Issue #1001).
During investigation I found that:
Linkwith a plain<a>prevents the freeze.preload={false}on theLinkalso prevents the freeze.MarkdownLink) already disable preloading.This change makes the framework card links consistent with the existing documentation link behavior and avoids the reported freeze.
I was not able to identify the underlying cause of the preload behavior, so this should be considered a workaround that resolves the reported issue rather than a confirmed root-cause fix.
Summary by CodeRabbit