feat: add renku-ci-cleanup chart#13
Open
wesjdj wants to merge 20 commits into
Open
Conversation
wesjdj
force-pushed
the
add-ci-deployment-cleanup
branch
from
July 15, 2025 11:15
7653acf to
232e567
Compare
wesjdj
marked this pull request as ready for review
July 15, 2025 11:59
leafty
reviewed
Jul 18, 2025
leafty
approved these changes
Aug 5, 2025
Member
|
@wesjdj feel free to merge this |
rokroskar
reviewed
Aug 6, 2025
| if [ "$ENFORCE_NAME_PATTERNS" = "true" ]; then | ||
| for pattern in $NAMESPACE_PATTERNS; do | ||
| debug_log "Testing pattern: $pattern" | ||
| if [[ "$namespace" =~ $pattern ]]; then |
Member
There was a problem hiding this comment.
this doesn't work for lookahead regex patterns like ^renku-ci-(?!cleanup).* so we should make sure not to use those
…anup # Conflicts: # pkg/cmd/cleanupdeployment.go # pkg/cmd/root.go
Member
|
We dont have to use this here or address this at all. Just fyi that all ci deployment namespaces now have the label |
leafty
reviewed
Jun 17, 2026
|
|
||
| namespace := viper.GetString("namespace") | ||
| deleteNamespace := viper.GetBool("delete-namespace") | ||
| yes := viper.GetBool("yes") |
Member
There was a problem hiding this comment.
Can we call this --skip-prompt? --yes is not very descriptive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automated cleanup of old CI deployments via a Kubernetes
CronJob.Added in-cluster config support to
rdu, and--yesflag to skip confirmation prompts. Both changes makerdueasier for the CronJob to use.