[Refactor] Use native timers/promises in sleep#8016
Conversation
Refactor the sleep utility function to use the modern setTimeout from node:timers/promises instead of a manual Promise wrapper. Added a unit test to verify the functionality and protect against regressions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Refactor the sleep utility function to use the modern setTimeout from node:timers/promises instead of a manual Promise wrapper. Added a unit test to verify the functionality and protect against regressions. verified that CI failures are pre-existing and unrelated to this change by running tests locally.
WHY are these changes introduced?
The
sleeputility function inpackages/cli-kitwas using a manualPromisewrapper around a callback-basedsetTimeout. Modern Node.js provides a native promisified version ofsetTimeoutin thenode:timers/promisesmodule, which is more idiomatic and maintainable.WHAT is this pull request doing?
sleepfunction inpackages/cli-kit/src/public/node/system.tsto usesetTimeoutfromnode:timers/promises.sleepfunction inpackages/cli-kit/src/public/node/system.test.tsto verify its behavior and ensure correctness.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 17141589781697498983 started by @gonzaloriestra