[Performance] Memoize cloudEnvironment check#8014
Conversation
Memoize the result of the `cloudEnvironment` function in `packages/cli-kit/src/public/node/context/local.ts` to avoid redundant environment variable lookups.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/context/local.d.ts@@ -173,4 +173,8 @@ export declare function getThemeKitAccessDomain(env?: NodeJS.ProcessEnv): string
* @returns The domain to send OTEL metrics to.
*/
export declare function opentelemetryDomain(env?: NodeJS.ProcessEnv): string;
-export type CIMetadata = Metadata;
\ No newline at end of file
+export type CIMetadata = Metadata;
+/**
+ * Resets the cloud environment cache.
+ */
+export declare function _resetCloudEnvironmentCache(): void;
\ No newline at end of file
|
WHY are these changes introduced?
The
cloudEnvironmentfunction is called multiple times during the CLI execution to identify if it's running in a cloud IDE like Codespaces or Gitpod. These environment checks are static during the process lifetime.WHAT is this pull request doing?
This PR memoizes the
cloudEnvironmentfunction result when using the defaultprocess.env. It also adds a reset utility for testing purposes.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 5739118917641376805 started by @gonzaloriestra