Use relative GraphiQL asset paths#8010
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/56dcddb4-0bb1-4e96-b794-1bb2fda2cba1
e346a0b to
b2f834b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
The GraphiQL server resolves package-local assets through
@shopify/cli-kit/...package imports. Newer Nx lint rules flag that as a same-project boundary violation and have blocked dependency-update PRs.WHAT is this pull request doing?
server.tsinstead of resolving them through the package import alias.How to test your changes?
pnpm nx run cli-kit:lintpnpm vitest run packages/cli-kit/src/public/node/graphiql/server.test.tspnpm nx run cli-kit:type-checkpnpm bundle-for-releasePost-release steps
None.
Checklist