Add non-interactive app dev prompt bypasses#7632
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ea50335 to
3948ce1
Compare
51b7815 to
63fab66
Compare
2014ea3 to
59259d8
Compare
4bd2cf5 to
986b2a7
Compare
59259d8 to
1f26176
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -7,6 +7,7 @@ export declare const environmentVariables: {
enableCliRedirect: string;
env: string;
firstPartyDev: string;
+ hostedApps: string;
noAnalytics: string;
optOutInstrumentation: string;
appAutomationToken: string;
packages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.1.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.0.0";
\ No newline at end of file
packages/cli-kit/dist/public/node/context/local.d.ts@@ -42,6 +42,13 @@ export declare function isShopify(env?: NodeJS.ProcessEnv): Promise<boolean>;
* @returns True if the SHOPIFY_UNIT_TEST environment variable is truthy.
*/
export declare function isUnitTest(env?: NodeJS.ProcessEnv): boolean;
+/**
+ * Returns true if the CLI is running in hosted apps mode.
+ *
+ * @param env - The environment variables from the environment of the current process.
+ * @returns True if the HOSTED_APPS environment variable is truthy.
+ */
+export declare function isHostedAppsMode(env?: NodeJS.ProcessEnv): boolean;
/**
* Returns true if reporting analytics is enabled.
*
|
1f26176 to
b0606fb
Compare
986b2a7 to
872015f
Compare
b0606fb to
c22f504
Compare
872015f to
81fed1d
Compare
155a4b3 to
bc9aaca
Compare
81fed1d to
950e211
Compare
bc9aaca to
b1b95a3
Compare
9c5a91a to
8cfe2a7
Compare
b1b95a3 to
2237293
Compare
8cfe2a7 to
e2500b0
Compare
2237293 to
9471955
Compare
9471955 to
8d194da
Compare
e2500b0 to
3913769
Compare
8d194da to
d849219
Compare
c82c565 to
aa85d78
Compare
2f2fa6d to
d3c61c4
Compare
aa85d78 to
5f73f48
Compare
d3c61c4 to
2dd690e
Compare
5f73f48 to
02fc84c
Compare
2dd690e to
847afd2
Compare
02fc84c to
278d226
Compare
| 'Install and use mkcert to generate localhost certificates when --use-localhost is enabled without prompting.', | ||
| env: 'SHOPIFY_FLAG_INSTALL_MKCERT', | ||
| default: false, | ||
| }), |
There was a problem hiding this comment.
this should probably have a dependsOn: localhost
Doesn't do anything on its own
There was a problem hiding this comment.
since this has a default, it might happen the same thing as in the other PR and assume it is always present and require localhost
847afd2 to
f25a459
Compare
278d226 to
b016c6e
Compare
b016c6e to
f3e0e23
Compare

WHY are these changes introduced?
Related to https://github.com/shop/issues-develop/issues/22868
The interactivity audit found several
app devpaths that still required prompts or manual recovery in automation:The transfer-disabled store conversion prompt is removed since the CLI only allows using dev stores now that should already be transfer-disabled.
WHAT is this pull request doing?
app devflags for non-interactive flows:--install-mkcert/SHOPIFY_FLAG_INSTALL_MKCERTcontrols localhost certificate installation.--store-password/SHOPIFY_FLAG_STORE_PASSWORDsupplies the storefront password needed by theme app extensions.automatically_update_urls_on_dev = true, avoiding the app dev URL prompt for that flow.app dev; transfer-enabled dev stores now fail with an actionable error instead of prompting to mutate the store.--store-passwordandSHOPIFY_FLAG_STORE_PASSWORDvalues from analytics payloads.How to test your changes?
shopify app dev --use-localhost --install-mkcertshopify app dev --store-password yourpasswordChecklist
pnpm changeset add