fix: error when invalidating a nonexistent environment#5878
Open
NishchayMahor wants to merge 1 commit into
Open
fix: error when invalidating a nonexistent environment#5878NishchayMahor wants to merge 1 commit into
NishchayMahor wants to merge 1 commit into
Conversation
sqlmesh invalidate ENVIRONMENT reported success even when the environment did not exist, so a mistyped name looked like it worked. Check the environment exists first and raise a clear error (nonzero exit) otherwise. Fixes SQLMesh#5621 Signed-off-by: Nishchay Mahor <nishchaymahor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sqlmesh invalidate ENVIRONMENTreports success even when the environment doesn't exist:That's misleading — a mistyped environment name looks like it worked. This checks that the environment exists first and raises a clear error with a nonzero exit code otherwise:
How
Context.invalidate_environmentnow looks the environment up viastate_sync.get_environmentbefore invalidating, and raisesSQLMeshErrorwhen it's absent (the CLI's@error_handlermaps that to exit code 1). The message and exception match the existing "environment not found" patterns already used elsewhere incontext.py.Testing
test_invalidate_environment_nonexistent_raises(fails without the fix).test_invalidate_environment_{sync,no_sync}and thetest_invalidating_environmentintegration test still pass.sqlmesh init duckdbproject: nonexistent env →Error: Environment '...' does not exist.with exit code 1.Fixes #5621