[mccall_q.md] Update np.random → Generator API#959
Open
Chihiro2000GitHub wants to merge 1 commit into
Open
Conversation
📖 Netlify Preview Ready!Preview URL: https://pr-959--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed LecturesBuild Info
|
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates legacy NumPy random API usage in
mccall_q.mdas part of QuantEcon/meta#299.np.random.seed(123)is replaced by an explicitrng = np.random.default_rng(123)(keeping the original fixed seed), and thenp.random.random()calls inside theQlearning_McCalljitclass are migrated torng.random(). Following the style guide for jitclass code,rngis passed in as a method argument rather than stored as a class attribute, and threaded throughrun_epochsand its call sites. The notebook executes successfully under Numba.Hi @mmcky and @HumphreyYang, I'd be grateful if you could take a look when you have time.