feat(wallet): wire PreferencesController into default initialization#9232
Open
sirtimid wants to merge 6 commits into
Open
feat(wallet): wire PreferencesController into default initialization#9232sirtimid wants to merge 6 commits into
PreferencesController into default initialization#9232sirtimid wants to merge 6 commits into
Conversation
sirtimid
added a commit
that referenced
this pull request
Jun 23, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
added a commit
that referenced
this pull request
Jun 23, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
force-pushed
the
sirtimid/wire-preferences-controller
branch
from
e951604 to
a8fd340
Compare
FrederikBolding
requested changes
Jun 23, 2026
Member
There was a problem hiding this comment.
Before we can do this, we will need metamask-extension and metamask-mobile to both be using PreferencesController from core.
Today they have diverged unfortunately.
EDIT: In theory, we may be able to wire in PreferencesController to wallet and override the initialization on extension to use the diverging version. But will depend on whether their state overlaps enough.
Member
Author
@FrederikBolding Mobile is already on vanilla core |
Member
Author
|
@metamaskbot publish-previews |
Member
Yeah, I realized that and added my EDIT. Have you verified that the controller state on extension is a superset of the We should de-risk by creating integration PRs regardless! |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
5 tasks
sirtimid
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jun 24, 2026
Add an integration test asserting PreferencesController.setAccountLabel routes through the wallet-delegated AccountsController:getAccountByAddress / :setAccountName (real wallet + override). Trim the override comments to the essential rationale and tie both runtime casts to MetaMask/core#9232 for removal once it ships. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
added a commit
that referenced
this pull request
Jun 25, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
force-pushed
the
sirtimid/wire-preferences-controller
branch
from
55f1664 to
68c1526
Compare
sirtimid
added a commit
that referenced
this pull request
Jun 25, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
force-pushed
the
sirtimid/wire-preferences-controller
branch
from
68c1526 to
a7c0a88
Compare
sirtimid
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jun 29, 2026
Add an integration test asserting PreferencesController.setAccountLabel routes through the wallet-delegated AccountsController:getAccountByAddress / :setAccountName (real wallet + override). Trim the override comments to the essential rationale and tie both runtime casts to MetaMask/core#9232 for removal once it ships. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
@FrederikBolding check the adoption PRs Extension — MetaMask/metamask-extension#43851 |
sirtimid
added a commit
that referenced
this pull request
Jun 29, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
force-pushed
the
sirtimid/wire-preferences-controller
branch
from
a7c0a88 to
4f9d41d
Compare
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
sirtimid
added a commit
that referenced
this pull request
Jul 1, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
force-pushed
the
sirtimid/wire-preferences-controller
branch
from
4f9d41d to
2eb41f6
Compare
Add `PreferencesController` to the default wallet initialization set. It has no cross-controller messenger dependencies and its only constructor inputs are `messenger` and `state`, so it wires with a plain namespaced child messenger and no `instanceOptions` slot — per-client values are supplied through the existing `state.PreferencesController` initial state. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Prove a consumer can keep a diverging superset PreferencesController by supplying its own initialization configuration under the same name, which overrides the package default — the adoption path for clients (e.g. the extension) that cannot converge to the package controller's state shape. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Re-export `InitializationConfiguration`, `InitFunctionArguments`, and `InstanceState` from the package root so consumers can annotate their own initialization configurations that override a default controller (e.g. the extension overriding the default `PreferencesController`). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the verbose breaking-change sub-bullet to match the one-line style of the other default-controller wiring entries. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
force-pushed
the
sirtimid/wire-preferences-controller
branch
from
2eb41f6 to
c03a9db
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Wires the
@metamask/preferences-controllerpackage into@metamask/wallet's default initialization. The defaultWalletnow constructs aPreferencesControllerand registers itsPreferencesController:*messenger actions (getState/stateChangeplus the preference setters), sowallet.state.PreferencesControllerand calls likePreferencesController:setIpfsGatewaywork out of the box.@metamask/walletis the shared controller-integration layer that the extension, mobile, and other clients adopt, so each controller is wired once here.PreferencesControllertakes no client-varying constructor values, so it needs no injectableinstanceOptions. Consumers can still replace the default by supplying aninitializationConfigurationsentry withname: 'PreferencesController'(e.g. a client-specific superset controller); this PR also exportsInitializationConfiguration,InitFunctionArguments, andInstanceStateso consumers can author that override.BREAKING: Clients that pass their own
messengerand already register aPreferencesControllermust drop that wiring before upgrading, or the duplicate messenger registration will collide. The adoption PRs below do exactly that.References
Client adoption PRs (construct
PreferencesControllerthrough@metamask/walletand delete the bespoke client init):Client construction sites (live
main):Jira: N/A
Checklist
🤖 Generated with Claude Code
Note
Medium Risk
Breaking messenger registration for any consumer still initializing PreferencesController separately; behavior is localized to wallet bootstrap but affects extension/mobile adoption.
Overview
BREAKING: Default
Walletinitialization now constructs@metamask/preferences-controller, registersPreferencesController:*messenger actions, and exposeswallet.state.PreferencesController. Clients that already wire their ownPreferencesControlleron a shared messenger must remove that wiring before upgrading or registration will collide.Adds a standard
preferencesControllerinitialization module (no newinstanceOptionsslot) and pulls in@metamask/preferences-controlleras a dependency. The package also exportsInitializationConfiguration,InitFunctionArguments, andInstanceStateso consumers can supply a same-named override (e.g. extension/mobile superset controllers) viainitializationConfigurations.Integration and unit tests cover default state, constructor initial state, messenger setters, and override behavior; CODEOWNERS and build/tsconfig references are updated accordingly.
Reviewed by Cursor Bugbot for commit 9505af7. Bugbot is set up for automated code reviews on this repo. Configure here.