Skip to content

More consistent document crate names#4323

Open
timon-schelling wants to merge 3 commits into
masterfrom
rename-document-crates
Open

More consistent document crate names#4323
timon-schelling wants to merge 3 commits into
masterfrom
rename-document-crates

Conversation

@timon-schelling

@timon-schelling timon-schelling commented Jul 10, 2026

Copy link
Copy Markdown
Member
[workspace.dependencies]
...
document-graph = { path = "document/graph", default-features = false }
document-format = { path = "document/format" }
document-container = { path = "document/container" }
...

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the graph-storage crate to document-graph and updates all references, imports, and documentation across the codebase to reflect this change. The review feedback identifies minor layout alignment issues in the ASCII art diagrams within the document-format.md RFC document caused by the difference in name lengths, and provides suggestions to correct the formatting.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread node-graph/rfcs/document-format.md Outdated
Comment thread node-graph/rfcs/document-format.md

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found and verified against the latest diff

Confidence score: 5/5

  • In node-graph/rfcs/document-format.md, the ASCII diagram border width is off by one character around document-graph, which can make the RFC harder to read or copy accurately but does not affect runtime behavior; this PR is safe to merge, and you can de-risk fully by fixing the box width/alignment before or immediately after merge.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/rfcs/document-format.md">

<violation number="1" location="node-graph/rfcs/document-format.md:214">
P3: The ASCII art box border is now misaligned — `document-graph` is one character longer than the previous `graph-storage`, so this line extends past the top/bottom borders. Remove one trailing space before the closing `│` to restore alignment.</violation>

<violation number="2" location="node-graph/rfcs/document-format.md:248">
P3: The ASCII art box right border is misaligned — `document-graph` is one character longer than the previous `graph-storage`, so this row is wider than the `┌───────────────┐` / `└───────────────┘` borders above and below. Remove the leading space before `document-graph` (or widen the entire box by 1 character) to fix the alignment.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/rfcs/document-format.md
Comment thread node-graph/rfcs/document-format.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant