Skip to content

Test all workspace crates in CI#4298

Open
YohYamasaki wants to merge 6 commits into
GraphiteEditor:masterfrom
YohYamasaki:ci-test-all-workspace
Open

Test all workspace crates in CI#4298
YohYamasaki wants to merge 6 commits into
GraphiteEditor:masterfrom
YohYamasaki:ci-test-all-workspace

Conversation

@YohYamasaki

@YohYamasaki YohYamasaki commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Introduce a custom cfg skip_desktop_license_embed because cfg(test) is false when this crate is compiled as a dependency of another crate.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@YohYamasaki YohYamasaki marked this pull request as draft July 1, 2026 05:56
@YohYamasaki YohYamasaki force-pushed the ci-test-all-workspace branch from 0de3c31 to 8932e1b Compare July 1, 2026 07:38
@YohYamasaki YohYamasaki marked this pull request as ready for review July 1, 2026 08:41

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TrueDoctor

Copy link
Copy Markdown
Member

@timon-schelling is this solution sufficiently clean? It does touch the desktop code

@YohYamasaki

Copy link
Copy Markdown
Contributor Author

I initially tried with cfg(test) but it did not work. Apparently because this crate is also built as a dependency of other crates, and cfg(test) is not enabled in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants