Remove legacy style-related structs#4297
Conversation
…crete types Store fill/stroke paints as List<Graphic> so Color/Gradient transitions do not hit set_attribute_value_dyn's type-mismatch fallback to default paint.
This reverts commit 9622feb.
# Conflicts: # node-graph/nodes/vector/src/vector_nodes.rs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the vector graphics style system by replacing the legacy Fill enum and PathStyle struct with a more flexible, attribute-based paint system using ATTR_FILL and ATTR_STROKE with AnyGraphicListDyn. The Stroke struct has been updated to remove its color field, which is now managed via attributes. Various tools, nodes (such as fill, stroke, boolean operations, and morphing), and document migration paths have been updated to support this new value-model paint system. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Part of #2779.
This PR is a follow-up to #4257. It must be merged first and then this branch will be rebased against the master.
As we now use attributes with
List<T>for the fill and stroke paints, some of the style-related structures and enumerations have become obsolete. This PR involves refactoring to remove these, such as...Legacy representations are kept only where needed for document migration.