Skip to content

refactor(generative_ai/evaluation): migrate vertexai.generative_models to genai SDK#14430

Open
XrossFox wants to merge 7 commits into
GoogleCloudPlatform:mainfrom
XrossFox:vertex-to-genai-generative-models
Open

refactor(generative_ai/evaluation): migrate vertexai.generative_models to genai SDK#14430
XrossFox wants to merge 7 commits into
GoogleCloudPlatform:mainfrom
XrossFox:vertex-to-genai-generative-models

Conversation

@XrossFox

@XrossFox XrossFox commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

sample: generative_ai/evaluation to genai/evaluation

  • Migrated evaluation samples to use the new google.genai SDK instead of vertexai.generative_models.
  • Removed unnecessary dependencies from requirements after testing confirmed they are no longer needed.

Fixes b/534795015

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style

Post-Approval Actions

  • Please merge this PR for me once it is approved

@XrossFox
refactor(generative_ai/evaluation): migrate vertexai.generative_mode…
aa4ace6 
…ls to genai SDK

 - Migrated evaluation samples to use the new `google.genai` SDK instead of `vertexai.generative_models`.
 - Removed unnecessary dependencies from requirements after testing confirmed they are no longer needed.
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jul 16, 2026
@gemini-code-assist

gemini-code-assist Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@XrossFox

XrossFox commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist

gemini-code-assist Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

XrossFox added 3 commits July 20, 2026 20:35
@XrossFox
- Migrated sample to new folder under genai.
f55a053 
- Refactored sample to use newer genai SDK.
- Cleaned requirements files from unneccessary dependencies.
@XrossFox
modified wrong file, undoing.
1183bf9
@XrossFox
linting issues fixed.
00b951b
@XrossFox

XrossFox commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Tests have been validated locally:

image image

@XrossFox
XrossFox marked this pull request as ready for review July 20, 2026 22:16
@XrossFox
XrossFox requested review from a team as code owners July 20, 2026 22:16
@snippet-bot

snippet-bot Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@XrossFox
XrossFox marked this pull request as draft July 20, 2026 22:17
Kef131
Kef131 reviewed Jul 21, 2026
View reviewed changes
Comment thread genai/evaluation/pairwise_summarization_quality.py Outdated
Kef131
Kef131 reviewed Jul 21, 2026
View reviewed changes
Comment thread genai/evaluation/pairwise_summarization_quality.py Outdated
Kef131
Kef131 reviewed Jul 21, 2026
View reviewed changes
Comment thread genai/evaluation/get_rouge_score.py Outdated
Kef131
Kef131 approved these changes Jul 21, 2026
View reviewed changes

@Kef131 Kef131 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for attending the comments, LGTM

@XrossFox
XrossFox marked this pull request as ready for review July 23, 2026 17:53
amcolin
amcolin requested changes Jul 23, 2026
View reviewed changes
Comment thread genai/evaluation/pairwise_summarization_quality.py Outdated
# [END aiplatform_genai_evaluation_pairwise_summarization_quality]


if __name__ == "__main__":

@amcolin amcolin Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the main function?

@XrossFox XrossFox Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread genai/evaluation/noxfile_config.py Outdated
@@ -0,0 +1,42 @@
# Copyright 2021 Google LLC

@amcolin amcolin Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to the current year

@XrossFox XrossFox Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread genai/evaluation/test_evaluation.py Outdated
@@ -0,0 +1,26 @@
# Copyright 2024 Google LLC

@amcolin amcolin Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the year here

@XrossFox XrossFox Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amcolin amcolin amcolin requested changes
@Kef131 Kef131 Kef131 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XrossFox @Kef131 @amcolin