fix(deps): pin lancedb to >=0.34.0,<0.35.0#355
Open
gloryfromca wants to merge 1 commit into
Open
Conversation
The previous open-ended `>=0.13.0` let any environment float to an untested release, including 0.32-0.34 which carry a compaction offset-overflow regression (lance-format/lance#7653) that stalls version cleanup and grows the index dir without bound. - Floor 0.34.0: the current resolved version; runs safely thanks to the with_position=False FTS workaround shipped in #336. Verified that data written by lancedb 0.32.0 (lance v6) reads correctly under 0.34.0 (lance v8), so existing deployments upgrade cleanly. Never widen the floor below 0.34 -- older lance cannot read v8-format data. - Ceiling <0.35.0: 0.35 embeds lance-rust v9 (large encoding jump, not yet stable-released); it must pass the soak harness before we allow it. Resolved version is unchanged (still 0.34.0); this only tightens the declared constraint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens the
lancedbdependency from the open-ended>=0.13.0to>=0.34.0,<0.35.0.The unbounded floor let any environment resolve to an untested lancedb
release. Versions 0.32.0 → 0.34.0 embed lance-rust v6/v7/v8, which
carry a compaction offset-overflow regression
(lance-format/lance#7653):
optimize()crashes while merging an unindexed tail of awith_positionFTS index, which stalls version cleanup and grows the index directory
without bound (observed 344 GB from ~24k rows on a user deployment).
0.34.0— the currently-resolved version. We run it safelyvia the
with_position=FalseFTS workaround shipped in fix(lancedb): disable FTS with_position to avoid optimize crash #336. Pinningthe floor here prevents silently dropping back to a version without
that mitigation.
<0.35.0— 0.35 embeds lance-rust v9 (the branch thatactually fixes #7653 upstream via lance#7546), but v9 is a large
encoding jump and has no stable release yet (0.35.0b2 is GitHub-release
only, not on PyPI). We gate the upgrade behind a soak-test harness
rather than floating onto it blindly.
Resolved version is unchanged (still
0.34.0); this only tightens thedeclared constraint and its
uv.lockspecifier.Area
Verification
Checklist
main.pyproject.toml.).envfiles, dependency folders, or generated output.Notes for Reviewers
<0.35.0ceiling is deliberate and should not be relaxed until thesoak harness validates 0.35.x. The inline comment in
pyproject.tomlrecords the rationale so a future dependency bump doesn't silently undo it.
0.34: older lance (v4, ≤0.30.2)cannot read v8-format data written by 0.34, so a downgrade would break
existing indexes (rebuild-from-md required). The upgrade direction is the
safe one, as verified above.
By submitting this pull request, I agree that my contribution is licensed under
the Apache License 2.0.