Skip to content

Deprecate xpay-handle-pay#9254

Open
Lagrang3 wants to merge 3 commits into
ElementsProject:masterfrom
Lagrang3:remove-pay-backend
Open

Deprecate xpay-handle-pay#9254
Lagrang3 wants to merge 3 commits into
ElementsProject:masterfrom
Lagrang3:remove-pay-backend

Conversation

@Lagrang3

@Lagrang3 Lagrang3 commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@rustyrussell deprecated pay in #9110, but he forgot to deprecate xpay-handle-pay.
This PR deprecates xpay-handle-pay for v26.09.

@Lagrang3
Lagrang3 force-pushed the remove-pay-backend branch from fa2c776 to fa8038a Compare July 1, 2026 07:31
@Lagrang3 Lagrang3 changed the title Remove pay backend Deprecated xpay-handle-pay Jul 1, 2026
@Lagrang3
Lagrang3 marked this pull request as ready for review July 1, 2026 07:34
@Lagrang3
Lagrang3 requested a review from cdecker as a code owner July 1, 2026 07:34
@Lagrang3
Lagrang3 requested a review from nGoline July 1, 2026 07:35
@Lagrang3
Lagrang3 force-pushed the remove-pay-backend branch 3 times, most recently from 89f8387 to 72d3263 Compare July 1, 2026 13:00
Lagrang3 added 2 commits July 9, 2026 15:14
@Lagrang3
libplugin: add macro to deprecate dynamic options
f1b340d 
Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@Lagrang3
xpay: deprecate xpay-handle-pay
472b4af 
Changelog-Deprecated: Config: option `xpay-handle-pay`, `pay` is deprecated and will be replaced by `xpay` in v27.03.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@Lagrang3
Lagrang3 force-pushed the remove-pay-backend branch from 72d3263 to 3660f6f Compare July 9, 2026 14:14
@Lagrang3
Lagrang3 requested a review from daywalker90 as a code owner July 9, 2026 14:14
@Lagrang3

Lagrang3 commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator Author
  • fixed errors in tests due to the deprecation,
  • rebased

@Lagrang3 Lagrang3 added the Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. label Jul 9, 2026
@Lagrang3 Lagrang3 added this to the v26.09 milestone Jul 9, 2026
@Lagrang3 Lagrang3 changed the title Deprecated xpay-handle-pay Deprecate xpay-handle-pay Jul 9, 2026
@Lagrang3
Lagrang3 force-pushed the remove-pay-backend branch from 3660f6f to cc78e39 Compare July 10, 2026 04:59
@Lagrang3

Lagrang3 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

After this afea381 in v26.06 we were having xpay processing all payments by default. This meant that tests/test_pay.py was not covering pay's legacy backend. Here I brought back those tests by explicitly running them with xpay-handle-pay in both True and False cases. Some tests that are not aiming at pay RPC
but test something else are preferred run with xpay because the pay command used is irrelevant.

These tests could have been enabled for xpay-handle-pay=False but they fail or are flaky:

  • test_pay_avoid_low_fee_chan

@Lagrang3
Lagrang3 force-pushed the remove-pay-backend branch 4 times, most recently from e84e771 to c500a89 Compare July 10, 2026 08:15
@Lagrang3
pay: add missing deprecation annotation
529fff9 
- add missing deprecation annotation to "pay" command,
- fix tests that required allow-deprecated-apis=True in order to
continue using "pay",
- change "pay" to "xpay" in those tests that
are NOT testing "pay" directly but just want to make a payment,
- and in tests that could be relevant for both "xpay" and "pay", use
  both.

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@Lagrang3
Lagrang3 force-pushed the remove-pay-backend branch from c500a89 to 529fff9 Compare July 10, 2026 09:14
daywalker90
daywalker90 reviewed Jul 13, 2026
View reviewed changes

@daywalker90 daywalker90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still usage of pay in test_invoices.py::test_invoice_deschash

Comment thread plugins/pay.c
"pay",
json_pay
json_pay,
"v26.06", "v27.03",

@daywalker90 daywalker90 Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a reason why rusty did not deprecate it here, but i can't find or remember it.

@Lagrang3 Lagrang3 Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please. Let me know.

@daywalker90 daywalker90 Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find it. My best guess is: not deprecate it to make it an alias for xpay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daywalker90 daywalker90 daywalker90 left review comments
@cdecker cdecker Awaiting requested review from cdecker cdecker is a code owner
@nGoline nGoline Awaiting requested review from nGoline

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

needs-rebase Status::Ready for Review The work has been completed and is now awaiting evaluation or approval.

Projects

None yet

Milestone

v26.09

Development

Successfully merging this pull request may close these issues.

2 participants

@Lagrang3 @daywalker90