Skip to content

Add is_enemy tag #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
creaturesofhabit wants to merge 2 commits into
base: dev
Choose a base branch
from
+23 −0
Open

Add is_enemy tag #2837

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa60327
Add is_enemy tag
creaturesofhabit Jul 22, 2026
8b19a3b
Added enemy matcher
creaturesofhabit Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions plugin/src/main/java/com/denizenscript/denizen/objects/EntityTag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,13 @@ public boolean isMonsterType() {
return getBukkitEntity() instanceof Monster;
}

public boolean isEnemyType() {

@MC-Samuel MC-Samuel Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a separate method and not part of the tag?

@creaturesofhabit creaturesofhabit Jul 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to entity matcher to match similar tags

if (getBukkitEntity() == null && entity_type != null) {
return Enemy.class.isAssignableFrom(entity_type.getBukkitEntityType().getEntityClass());
}
return getBukkitEntity() instanceof Enemy;

@MC-Samuel MC-Samuel Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be all that's required.

@BehrRiley BehrRiley Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entity_type check allows unspawned entities (eg, <entity[zombie].is_enemy>) to check correctly when getBukkitEntity() is null

}

public boolean isMobType() {
if (getBukkitEntity() == null && entity_type != null) {
return Mob.class.isAssignableFrom(entity_type.getBukkitEntityType().getEntityClass());
Expand Down Expand Up @@ -2372,6 +2379,20 @@ else if (object.getBukkitEntity() instanceof Hanging hanging) {
return new ElementTag(object.isMonsterType());
});

if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_19)) {

// <--[tag]
// @attribute <EntityTag.is_enemy>
// @returns ElementTag(Boolean)
// @group data
// @description
// Returns whether the entity type is an enemy. See <@link url https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/Enemy.html>

@MC-Samuel MC-Samuel Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the link is necessary, unless you're referencing entities that Spigot defines as "enemies"?

// -->
tagProcessor.registerTag(ElementTag.class, "is_enemy", (attribute, object) -> {
return new ElementTag(object.isEnemyType());
});
}

// <--[tag]
// @attribute <EntityTag.is_mob>
// @returns ElementTag(Boolean)
Expand Down Expand Up @@ -4587,6 +4608,8 @@ public final boolean trySpecialEntityMatcher(String text, boolean isNPC) {
return isMobType();
case "animal":
return isAnimalType();
case "enemy":
return isEnemyType();
}
return false;
}
Expand Down