fix look command offthread_repeat math and mounted rotation#2836
Open
BehrRiley wants to merge 3 commits into
Open
fix look command offthread_repeat math and mounted rotation#2836BehrRiley wants to merge 3 commits into
offthread_repeat math and mounted rotation#2836BehrRiley wants to merge 3 commits into
Conversation
MC-Samuel
reviewed
Jul 22, 2026
| if (entity.isSpawned()) { | ||
| if (loc != null) { | ||
| NMSHandler.entityHelper.faceLocation(entity.getBukkitEntity(), loc); | ||
| org.bukkit.entity.Entity bukkitEntity = entity.getBukkitEntity(); |
Contributor
There was a problem hiding this comment.
Can clean up FQN for these.
|
|
||
| if (loc != null) { | ||
| NMSHandler.entityHelper.faceLocation(bukkitEntity, loc); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Can make this else if (entity.isPlayer)) { and shift the below sections over.
- refactor LookCommand `FQN`s and control flow - format brackets and remove `FQN`s in `LookCommand`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This update resolves two distinct issues with the look command:
Problem
offthread_repeatargument applied the total relative yaw and pitch repeatedly instead of splitting them into fractional step incrementsRETAIN_VEHICLEand tightened teleport and rotation restrictions, causing mounted entities and players to fail look updatesSolution
offthread_repeatsplits the relative yaw and pitch into fractional step increments instead of repeatedly applying the total distanceTesting, References: