Fix flaky PayloadDispatcherImplTest by stubbing getRootSpan#11873
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoJul 7, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🎯 Code Coverage (details) 🔗 Commit SHA: 2c8b8f5 | Docs | Datadog PR Page | Give us feedback! |
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
mhlidd
approved these changes
Jul 6, 2026
bric3
approved these changes
Jul 7, 2026
mcculls
approved these changes
Jul 7, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
32c13ee
into
master
599 of 604 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Stubs
getRootSpan()on thePendingTracestub inPayloadDispatcherImplTest.realSpan()so it returns the real span instead of letting Spock fabricate a dummy on every call.Motivation
The test
flush automatically when data limit is breachedwas flaky on CI withSpockTimeoutError: Method timed out after 10.00 seconds.getRootSpan()returnsDDSpan(a concrete class with no no-arg constructor). Since it was left unstubbed, every serialization pass in the tightwhile (!flushed.get())loop hit Spock'sEmptyOrDummyResponse, which triedClass.newInstance()(→InstantiationException) and fell back to expensive reflection/ByteBuddy. Accumulated across all iterations, this intermittently blew the 10s@Timeouton loaded CI runners.Additional Notes
Behavior is unchanged: the span is a single-span trace, so it is its own root —
getRootSpanContextIfDifferent()still resolves tothis. The fix just removes the per-call reflection cost, making the loop fast and deterministic.Test failed on CI with the following stack trace: