Skip to content

Limit OpenFeature fixture submodule updates#11867

Open
leoromanovsky wants to merge 2 commits into
masterfrom
leo.romanovsky/limit-openfeature-submodule-dependabot
Open

Limit OpenFeature fixture submodule updates#11867
leoromanovsky wants to merge 2 commits into
masterfrom
leo.romanovsky/limit-openfeature-submodule-dependabot

Conversation

@leoromanovsky

@leoromanovsky leoromanovsky commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

PR #11355 added Dependabot updates for git submodules so the OpenFeature fixture corpus can stay current. Because the rule was scoped to the repository root without an allow-list, Dependabot also started opening JMX Fetch submodule updates, such as #11863. Those updates should remain owned by the existing JMX/APM Java flow, while OpenFeature fixture updates should be labeled and routed to the FFE SDK team.

Changes

This PR restricts the gitsubmodule Dependabot rule to dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data using an explicit allow entry.

It also applies the expected labels to generated OpenFeature fixture submodule PRs:

  • comp: openfeature
  • tag: dependencies
  • tag: no release notes

Decisions

I kept directory: / because Dependabot reads git submodules from the repository .gitmodules file. The narrower allow rule is the guardrail that prevents the same automation from updating dd-java-agent/agent-jmxfetch/integrations-core.

The follow-up request also asked about CODEOWNERS assignment. I checked that path before changing it: the existing /dd-smoke-tests/openfeature/ CODEOWNERS rule already covers dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data, including the submodule gitlink path that changes in fixture update PRs. Adding an exact duplicate owner line would not change routing, so this PR intentionally leaves CODEOWNERS unchanged.

Validation

  • ruby -e "require 'yaml'; YAML.load_file('.github/dependabot.yml'); puts 'dependabot.yml OK'"
  • git config -f .gitmodules --get-regexp '^submodule\\..*\\.path$'
  • git diff --check

@leoromanovsky leoromanovsky added type: bug fix Bug fix comp: openfeature OpenFeature tag: dependencies Dependencies related changes tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Jul 6, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 6, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 56.93% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3791026 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.70 s 14.68 s [-0.8%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 13.45 s 13.64 s [-2.0%; -0.7%] (maybe better)
startup:petclinic:appsec:Agent 16.41 s 16.15 s [-4.6%; +7.9%] (unstable)
startup:petclinic:iast:Agent 16.83 s 16.86 s [-1.0%; +0.7%] (no difference)
startup:petclinic:profiling:Agent 16.81 s 16.95 s [-2.1%; +0.5%] (no difference)
startup:petclinic:sca:Agent 16.92 s 16.67 s [+0.3%; +2.6%] (maybe worse)
startup:petclinic:tracing:Agent 15.74 s 16.20 s [-6.9%; +1.2%] (no difference)

Commit: 37910260 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@leoromanovsky leoromanovsky marked this pull request as ready for review July 6, 2026 14:09
@leoromanovsky leoromanovsky requested a review from a team as a code owner July 6, 2026 14:09
@leoromanovsky leoromanovsky requested review from PerfectSlayer and removed request for a team July 6, 2026 14:09

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up commit!

@leoromanovsky leoromanovsky enabled auto-merge July 6, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: openfeature OpenFeature tag: ai generated Largely based on code generated by an AI or LLM tag: dependencies Dependencies related changes tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants