Limit OpenFeature fixture submodule updates#11867
Open
leoromanovsky wants to merge 2 commits into
Open
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 3791026 | Docs | Datadog PR Page | Give us feedback! |
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
PerfectSlayer
approved these changes
Jul 6, 2026
PerfectSlayer
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the follow up commit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #11355 added Dependabot updates for git submodules so the OpenFeature fixture corpus can stay current. Because the rule was scoped to the repository root without an allow-list, Dependabot also started opening JMX Fetch submodule updates, such as #11863. Those updates should remain owned by the existing JMX/APM Java flow, while OpenFeature fixture updates should be labeled and routed to the FFE SDK team.
Changes
This PR restricts the
gitsubmoduleDependabot rule todd-smoke-tests/openfeature/src/test/resources/ffe-system-test-datausing an explicitallowentry.It also applies the expected labels to generated OpenFeature fixture submodule PRs:
comp: openfeaturetag: dependenciestag: no release notesDecisions
I kept
directory: /because Dependabot reads git submodules from the repository.gitmodulesfile. The narrowerallowrule is the guardrail that prevents the same automation from updatingdd-java-agent/agent-jmxfetch/integrations-core.The follow-up request also asked about CODEOWNERS assignment. I checked that path before changing it: the existing
/dd-smoke-tests/openfeature/CODEOWNERS rule already coversdd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data, including the submodule gitlink path that changes in fixture update PRs. Adding an exact duplicate owner line would not change routing, so this PR intentionally leaves CODEOWNERS unchanged.Validation
ruby -e "require 'yaml'; YAML.load_file('.github/dependabot.yml'); puts 'dependabot.yml OK'"git config -f .gitmodules --get-regexp '^submodule\\..*\\.path$'git diff --check