chore(deps): bump dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from b42c4a1 to a596df7#11862
Conversation
…ystem-test-data Bumps [dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `b42c4a1` to `a596df7`. - [Commits](DataDog/ffe-system-test-data@b42c4a1...a596df7) --- updated-dependencies: - dependency-name: dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data dependency-version: a596df75dca040c46078b768cd2536c67691523c dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
PR Blocked - Invalid Label The pull request introduced unexpected labels:
This PR is blocked until:
Note: Simply removing labels from the pull request is not enough - a maintainer must delete this comment then remove the label to remove the block. |
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b86e93b4d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit b42c4a104ea70695c8fc3516780951f7434b7906 | |||
| Subproject commit a596df75dca040c46078b768cd2536c67691523c | |||
There was a problem hiding this comment.
This submodule revision adds/changes smoke-test fixtures that the current Java evaluator does not satisfy. For example, the updated temporal fixtures now expect reason: DEFAULT, while DDEvaluator.resolveVariant still returns STATIC for active allocations with no rules or shards (products/feature-flagging/feature-flagging-api/src/main/java/datadog/trace/api/openfeature/DDEvaluator.java lines 398-401), and the new malformed/unknown-operator fixtures expect default results even though the deserializer drops those flags and evaluate reports FLAG_NOT_FOUND (lines 101-103). Since OpenFeatureProviderSmokeTest asserts responseBody.reason == testCase.result.reason, the bumped smoke tests will fail until the evaluator/deserializer semantics are updated or these incompatible fixtures are excluded.
Useful? React with 👍 / 👎.
| @@ -1 +1 @@ | |||
| Subproject commit b42c4a104ea70695c8fc3516780951f7434b7906 | |||
| Subproject commit a596df75dca040c46078b768cd2536c67691523c | |||
There was a problem hiding this comment.
This revision's ufc-config.json includes malformed-allocations-flag where allocations is the string "this-is-not-a-list", but OpenFeatureProviderSmokeTest.buildLoggedAllocations iterates every raw definition.allocations value and immediately reads allocation.key/allocation.doLog (OpenFeatureProviderSmokeTest.groovy lines 207-210). In this bumped config the @Shared loggedAllocations initializer will encounter that string and throw a missing-property error before the smoke tests can even evaluate the cases, so the helper needs to ignore non-list allocations (or otherwise tolerate malformed flags) independently of evaluator fixes.
Useful? React with 👍 / 👎.
| @@ -1 +1 @@ | |||
| Subproject commit b42c4a104ea70695c8fc3516780951f7434b7906 | |||
| Subproject commit a596df75dca040c46078b768cd2536c67691523c | |||
There was a problem hiding this comment.
The bumped ufc-config.json now intentionally contains malformed flags (for example a string-valued allocations and an out-of-range totalShards), but DDEvaluatorTest.loadCanonicalConfiguration still parses the whole file with a plain Moshi CONFIG_ADAPTER instead of the tolerant UniversalFlagConfigDeserializer used by remote config. When testEvaluateCanonicalFixture runs against this revision, that parser will throw while loading the config before any evaluator assertions run, so the canonical fixture tests need to use the same per-flag-tolerant deserializer or skip malformed fixtures deliberately.
Useful? React with 👍 / 👎.
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
1 participant
Bumps dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from
b42c4a1toa596df7.Commits
a596df7Merge pull request #17 from DataDog/leo.romanovsky/regex-shard-bound-fixturesce45493Add regex and shard-bound fixtures6c7f63bMerge pull request #16 from DataDog/leo.romanovsky/malformed-split-shards-fix...cf7d7d5Add missing split shards fixtured9d8020Merge pull request #15 from DataDog/leo.romanovsky/date-window-assignment-rea...e4803e3Fix temporal allocation reasons95ff628Fix date-window assignment reasons57e98f5Merge pull request #14 from DataDog/leo.romanovsky/add-regex-evaluation-cases6db17e8Add regex evaluation edge cases1db25ecMerge pull request #11 from DataDog/leo.romanovsky/ffe-malformed-config-casesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)