Replace onAttach / onDetach context event pair with onUpdate(before, after)#11859
Open
mcculls wants to merge 1 commit into
Open
Replace onAttach / onDetach context event pair with onUpdate(before, after)#11859mcculls wants to merge 1 commit into
onAttach / onDetach context event pair with onUpdate(before, after)#11859mcculls wants to merge 1 commit into
Conversation
mcculls
added
comp: core
mcculls
requested review from
PerfectSlayer and
bric3
and removed request for
a team
|
🎯 Code Coverage (details) 🔗 Commit SHA: c0c3c75 | Docs | Datadog PR Page | Give us feedback! |
Contributor
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
mcculls
force-pushed
the
mcculls/context-update-event
branch
from
4d37ba4 to
1c76b54
Compare
mcculls
force-pushed
the
mcculls/context-update-event
branch
from
1c76b54 to
c0c3c75
Compare
PerfectSlayer
approved these changes
Jul 6, 2026
PerfectSlayer
left a comment
PerfectSlayer
left a comment
Contributor
There was a problem hiding this comment.
Looking good! I like the fact there is no longer a "before" event (onDettach) so all notifications happen after the related context event is resolved.
| try (ContextScope scope = context.attach()) { | ||
| continuation = context.capture(); // capture while active | ||
| continuation.hold(); | ||
| listener.assertNewEvents("update:{root}->value", "capture:value"); |
Contributor
There was a problem hiding this comment.
👏 praise: Like the fact the events moved near where they happen. The tests are stricter and easier to read 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reduces event cost while allowing listeners to detect the difference between updates to/from
rootand those updating from one non-root context to another.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]