-
Notifications
You must be signed in to change notification settings - Fork 344
Test JDK 27 as a non-default JVM #11841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
358c19f
Test EA JDK 27
sarahchen6 2d17441
Add JDK 27 tests
sarahchen6 8cad4f9
Merge branch 'master' into sarahchen6/test-jdk-27
sarahchen6 10a5902
Revert to ci- image prefix
sarahchen6 5425bc0
Skip failing JDK 27 tests
sarahchen6 0c7f911
Merge branch 'master' into sarahchen6/test-jdk-27
sarahchen6 24c077f
Remove 27 from DEFAULT_TEST_JVMS
sarahchen6 847496f
Clean up
sarahchen6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent test execution across CI matrix: amd64 test jobs will skip Java 27 on PR validation unless NON_DEFAULT_JVMS is explicitly set, while arm64 runs it by default. This defeats the stated goal of 'preparing to support JDK 27' — if tests don't run on PRs, integration issues won't be caught before master.
Assertion details
Java 27 tests should run with consistent default treatment across all test jobs. The global DEFAULT_TEST_JVMS should either include 27 (matching the matrix), or all jobs using .test_matrix should explicitly override it.Global DEFAULT_TEST_JVMS at line 60 is /^(8|11|17|21|25|tip)$/ (no 27). When a job runs with testJvm=27, the CI rule 'if: $testJvm =~ $DEFAULT_TEST_JVMS' evaluates to false, causing the job to not run (or only run on master/mq branches). Individual overrides exist for .test_job_arm64 (line 748), muzzle-dep-report, and test_debugger, but base .test_job jobs without overrides inherit the stale global regex.Was this helpful? React 👍 or 👎
🤖 Datadog Autotest · What is Autotest? · Any feedback? Reach out in #autotest
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we exclude it in DEFAULT_JVMs is to avoid extra CI running for PRs, though JDK 27 EA is still run for all tests on MQ and
masterpipelines. It's fine to have the JDK 27 EA image run extra, i.e. on PRs, especially for smaller test jobs such arm64 and debugger below.