Skip to content

fix: read-idle timeout on SSE so a stalled stream can't hang events()#15

Merged
wei-hai merged 1 commit into
mainfrom
fix/sse-idle-timeout
Jul 22, 2026
Merged

fix: read-idle timeout on SSE so a stalled stream can't hang events()#15
wei-hai merged 1 commit into
mainfrom
fix/sse-idle-timeout

Conversation

@wei-hai

@wei-hai wei-hai commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Found running a real >10-minute job against prod: the SSE stream went silent at ~3 min (no frames, no keepalive, no close — a "zombie" connection), and job.events() hung — still blocked minutes after the job had already completed. poll/wait/run were unaffected (the job itself finished fine).

Root cause

iterateSse read the fetch body with no idle timeout, so it blocks forever on a stalled-but-open connection. The high-level Job.events() reconnect/poll-fallback only runs when the stream ends (the async iterator returns or throws), which never happens for a zombie → events() hangs.

Fix

Add a byte-level read-idle timeout to iterateSse (default SSE_IDLE_TIMEOUT_MS, well above the server keepalive interval). It resets on any bytes — so keepalive comments (which eventsource-parser drops as non-messages) still count as liveness, and only a truly silent connection trips it. A stalled stream now errors, which Job.events() already catches and turns into a poll (terminal?) / reconnect.

Tests

Added a regression test: a stream that emits two frames then holds open + silent → iterateSse errors quickly (~idle timeout) instead of hanging, after delivering the pre-stall frames. Full suite green; tsc/oxfmt/hygiene clean.

🤖 Generated with Claude Code

A live-events SSE connection that goes silent-but-open (no frames, no
keepalive, no close — e.g. a gateway idle timeout on a long job) blocked
iterateSse forever. The high-level Job.events() reconnect/poll-fallback only
runs when the stream *ends*, so it never recovered — events() hung
indefinitely on jobs longer than a few minutes, even though the job itself
completed fine (poll/wait/run stayed correct).

Add a byte-level read-idle timeout to iterateSse (default SSE_IDLE_TIMEOUT_MS,
well above the server's keepalive interval; reset on any bytes, so keepalive
comments count as liveness). A stalled stream now errors, which Job.events()
already catches and turns into a poll/reconnect. Adds a regression test.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@wei-hai
wei-hai requested review from a team as code owners July 22, 2026 04:53
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@wei-hai, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5131d329-d397-40b7-b5ea-fd41483b2203

📥 Commits

Reviewing files that changed from the base of the PR and between 2b2fd6f and 6f2e83a.

📒 Files selected for processing (2)
  • src/low/sse.test.ts
  • src/low/sse.ts

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Too big: expected string to have <=250 characters at "tone_instructions"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sse-idle-timeout
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/sse-idle-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wei-hai
wei-hai merged commit 5f7c428 into main Jul 22, 2026
7 checks passed
@wei-hai
wei-hai deleted the fix/sse-idle-timeout branch July 22, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant