fix: map entity-specific 404 codes in high-level toSdkError#14
Conversation
The prior fix only added job_not_found/asset_not_found to the low-level error map; the high-level toSdkError (what the client actually surfaces to callers) has its own code map that still fell through to a generic ComfyError for a missing job/asset. Add the codes there too, with a test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Warning
|
Follow-up to #13. That fix added
job_not_found/asset_not_found→NotFoundto the low-level error map, but the high-leveltoSdkError(insdk/exceptions.ts, what the client actually surfaces) has its own code map that still fell through to a genericComfyError. So a missing job/asset was still not a typedNotFoundat the SDK surface.Add the codes to the high-level map too, with a test. Found while running the TS SDK through prod conformance.
🤖 Generated with Claude Code