Skip to content

fix: map entity-specific 404 codes in high-level toSdkError#14

Merged
wei-hai merged 1 commit into
mainfrom
fix/highlevel-notfound-codes
Jul 22, 2026
Merged

fix: map entity-specific 404 codes in high-level toSdkError#14
wei-hai merged 1 commit into
mainfrom
fix/highlevel-notfound-codes

Conversation

@wei-hai

@wei-hai wei-hai commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #13. That fix added job_not_found/asset_not_foundNotFound to the low-level error map, but the high-level toSdkError (in sdk/exceptions.ts, what the client actually surfaces) has its own code map that still fell through to a generic ComfyError. So a missing job/asset was still not a typed NotFound at the SDK surface.

Add the codes to the high-level map too, with a test. Found while running the TS SDK through prod conformance.

🤖 Generated with Claude Code

The prior fix only added job_not_found/asset_not_found to the low-level
error map; the high-level toSdkError (what the client actually surfaces to
callers) has its own code map that still fell through to a generic
ComfyError for a missing job/asset. Add the codes there too, with a test.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@wei-hai
wei-hai requested review from a team as code owners July 22, 2026 01:26
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@wei-hai, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6a20b874-b948-4c58-9d52-7be395f9709f

📥 Commits

Reviewing files that changed from the base of the PR and between 5425e93 and 8e60ed2.

📒 Files selected for processing (2)
  • src/sdk/exceptions.test.ts
  • src/sdk/exceptions.ts

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Too big: expected string to have <=250 characters at "tone_instructions"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/highlevel-notfound-codes
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/highlevel-notfound-codes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wei-hai
wei-hai merged commit 2b2fd6f into main Jul 22, 2026
7 checks passed
@wei-hai
wei-hai deleted the fix/highlevel-notfound-codes branch July 22, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant