London | 26-ITP-May | Vito Moratti | Sprint 3 | Implement and rewrite#1524
London | 26-ITP-May | Vito Moratti | Sprint 3 | Implement and rewrite#1524vmoratti wants to merge 52 commits into
Conversation
QQ quit
Implement isProperFraction function to check if a fraction is proper.
Function 'getCardValue' is marked for implementation.
Added a test case for zero numerator and removed duplicate test case.
Updated test file to include Jest syntax and added test cases for Ace and number cards.
Added a test case for the Ace card in Jest syntax.
Add suggestion to group test cases for better organization.
Removed unnecessary comments about Jest documentation.
Added implementation notes for repeatStr function.
Added comments to categorize test data and provide guidance on error testing.
Commented out the return statement for '1st' in the getOrdinalNumber function.
Updated comments to clarify implementation requirements for repeatStr function.
vmoratti
left a comment
vmoratti
left a comment
There was a problem hiding this comment.
I have cleaned up my to match the original one
vmoratti
added
the
Needs Review
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
vmoratti
left a comment
vmoratti
left a comment
There was a problem hiding this comment.
adjusted my code to match the original
vmoratti
added
the
Needs Review
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
vmoratti
left a comment
vmoratti
left a comment
There was a problem hiding this comment.
adjusted my code to match the original
vmoratti
added
the
Needs Review
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
1 participant
Self checklist
Changelist
Complete coursework for Sprint 3, except stretch
Questions