Skip to content

Manchester | 26-ITP-May | Szidonia Bodo | Sprint 3 | Dead Code #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bodoszidi wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −6
Open

Manchester | 26-ITP-May | Szidonia Bodo | Sprint 3 | Dead Code #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54f9242
removed redundant and code
bodoszidi Jul 16, 2026
634b743
removed dead unused code
bodoszidi Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sprint-3/3-dead-code/exercise-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ let testName = "Jerry";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
//const greetingStr = greeting + ", " + name + "!";
// - removing this line as this is redundant code and duplicated inside the return
return `${greeting}, ${name}!`;
console.log(greetingStr);
//console.log(greetingStr);
// - removing this line because after return the console.log will not execute
}

testName = "Aman";
Expand Down
11 changes: 7 additions & 4 deletions Sprint-3/3-dead-code/exercise-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
// const capitalisedPets = pets.map((pet) => pet.toUpperCase());
// -- Removing this because countAndCapitalisePets already capitalises each pet. --redundant code
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}
// function logPets(petsArr) {
// petsArr.forEach((pet) => console.log(pet));
// }

// --logPets does not effect the final console.log - unused code

function countAndCapitalisePets(petsArr) {
const petCount = {};
Expand Down
Loading