London | 26-ITP-May | Mandip sanger | Sprint 1 | Coursework by mandipsanger · Pull Request #1516 · CodeYourFuture/Module-Structuring-and-Testing-Data

mandipsanger · 2026-07-15T16:23:37Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

added tasks from sprint1

hey-hammad · 2026-07-16T10:26:25Z

@@ -1,9 +1,12 @@
-const cardNumber = 4533787178994213;
+const cardNumber = "4533787178994213";


Suppose you're not allowed to modify the original value. How would you achieve this using code alone?

hey-hammad · 2026-07-16T10:28:38Z

 const 12HourClockTime = "8:53pm";
 const 24hourClockTime = "20:53";
+
+// 12 Hour clock time is a string that represents the time in 12-hour format, while 24hourClockTime is a string that represents the time in 24-hour format.


please review this code again, you need to fix the error in the file.

hey-hammad · 2026-07-16T10:31:52Z

 const result = `${totalHours}:${remainingMinutes}:${remainingSeconds}`;
 console.log(result);
+// There are 6 variables declared in this program: movieLength, remainingSeconds, totalMinutes, remainingMinutes, totalHours, and result.
+// There are 4 function calls in this program: console.log(), and the three arithmetic operations used to calculate remainingSeconds, totalMinutes, and remainingMinutes.


please review this answer again, and double-check what counts as a function call in JavaScript

count is how many time fuction been called. In this case its result been called only once.

hey-hammad · 2026-07-16T10:32:38Z

+// Interpret line 4, the expression assigned to totalMinutes calculates the total number of minutes in the movie by subtracting the remaining seconds from the total length of the movie and dividing by 60.
+// The variable result represents the formatted string of the movie length in hours, minutes, and seconds. A better name for this variable could be formattedMovieLength or movieLengthString.
+// This code will work for all values of movieLength, as it correctly calculates the hours, minutes, and seconds regardless of the total length of the movie. However, if movieLength is negative, it may not produce a meaningful result.
+// experimenting with different values of movieLength, such as 2:25.833, 1:23:20, will show that the code correctly formats the length of the movie in hours, minutes, and seconds for all positive values.


try testing a wider range of values and consider whether there are any inputs that produce unexpected output or formatting.

the range is only allowed in seconds

hey-hammad · 2026-07-16T10:36:04Z


 // To begin, we can start with
 // 1. const penceString = "399p": initialises a string variable with the value "399p"
+// const penceString = "399p": initialises a string variable with the value "399p"


Good start, but please play around with the code and try explaining the rationale behind each step. For example, why is padding needed here?

Thank you I will look into these again

Padding is used to make sure the number has the correct number of digits before it is split into pounds and pence.padStart(3, "0") adds zeros to the beginning of the string until it is at least 3 characters long.

github-actions · 2026-07-16T15:21:50Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-errors/0.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-07-16T15:24:17Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-errors/0.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

hey-hammad · 2026-07-17T10:17:27Z

 // call the function capitalise with a string input
 // interpret the error message and figure out why an error is occurring

+// function capitalise(str) {


please remove the sprint 2 changes from this PR. Thanks

Sorry thank you letting me know.

github-actions · 2026-07-17T10:20:06Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-errors/0.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

mandipsanger added 11 commits July 15, 2026 17:03

add count

29b8f8d

add initials

faa06ac

add paths

89a2103

add randoms

3c3188f

add errors task 0

61147c7

add errors task1

6b062a6

add errors task2

103bc69

add errors task3

5d11b8f

add errors task4

7cd725a

add time format

79e1444

add to pounds

6fca6cb

mandipsanger added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 15, 2026

hey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 16, 2026

hey-hammad reviewed Jul 16, 2026

View reviewed changes

hey-hammad added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 16, 2026

mandipsanger added 4 commits July 16, 2026 15:15

fix errors without changes

1cd3d6d

fix error in 4js

5775809

fix errors in time

1bf7cd3

fix all errors

0664359

mandipsanger removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jul 16, 2026

mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 16, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 16, 2026

hey-hammad reviewed Jul 17, 2026

View reviewed changes

hey-hammad added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jul 17, 2026

		@@ -1,9 +1,12 @@
		const cardNumber = 4533787178994213;
		const cardNumber = "4533787178994213";

Uh oh!

Uh oh!

Conversation

mandipsanger commented Jul 15, 2026

Learners, PR Template

Changelist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hey-hammad Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

hey-hammad Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hey-hammad Jul 16, 2026 •

edited

Loading

hey-hammad Jul 17, 2026 •

edited

Loading