Skip to content

London | 26-ITP-May | Rizqah Popoola| Sprint 3 | Dead Code#1499

Open
risikatpopoola wants to merge 2 commits into
CodeYourFuture:mainfrom
risikatpopoola:sprint-3-dead-code
Open

London | 26-ITP-May | Rizqah Popoola| Sprint 3 | Dead Code#1499
risikatpopoola wants to merge 2 commits into
CodeYourFuture:mainfrom
risikatpopoola:sprint-3-dead-code

Conversation

@risikatpopoola

@risikatpopoola risikatpopoola commented Jul 12, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

redundant code removed for the deadcode exercise

@risikatpopoola risikatpopoola added 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 12, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 14, 2026
Comment thread Sprint-3/3-dead-code/exercise-1.js Outdated
// The sayHello function should continue to work for any reasonable input it's given.

let testName = "Jerry";
//let testName = "Jerry";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions say to remove lines code that aren't used - please re-do, make sure you're deleting not needed lines

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now done this, thank you.

Comment thread Sprint-3/3-dead-code/exercise-1.js Outdated

@Poonam-raj Poonam-raj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work identifying the lines not needed - read instructions carefully and delete these before submitting.

@Poonam-raj Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 14, 2026
@risikatpopoola risikatpopoola added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants