Manchester | 26-ITP-May | John Robinson | Sprint 2 | Coursework#1495
Open
JohnRob-jnr wants to merge 2 commits into
Open
Manchester | 26-ITP-May | John Robinson | Sprint 2 | Coursework#1495JohnRob-jnr wants to merge 2 commits into
JohnRob-jnr wants to merge 2 commits into
Conversation
JohnRob-jnr
added
📅 Sprint 2
LonMcGregor
reviewed
Jul 15, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, and well done for trying the stretch task. I have a question about the stretch task tests.
| console.assert( | ||
| currentOutput4 === targetOutput4, | ||
| `current output: ${currentOutput4}, target output: ${targetOutput4}` | ||
| ); No newline at end of file |
There was a problem hiding this comment.
With testing the goal is to ensure all branches of code are tested. Are all the main edge cases covered by your tests?
Author
There was a problem hiding this comment.
Thanks for the feedback, would I be right in thinking that 24:00 was a missing test? I have added this & done the pull request
LonMcGregor
added
Reviewed
JohnRob-jnr
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Submission of coursework for Sprint 2