Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 3 | Coursework with jest

[meneogbemi42-bit]

##Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

This PR implements the Sprint-3 exercise solutions and adds rewritten Jest tests — it implements three functions (getAngleType, isProperFraction, getCardValue), adds input validation/edge-case handling, and adds comprehensive Jest test suites for each.

[LonMcGregor]

Good start on this task, lots of good varied test cases. I've got a couple of comments about your implementations

[LonMcGregor]

Could you combine this condition with the returned expression below?

[meneogbemi42-bit]

ok, that escape me iniatially. thanks for the observation

[LonMcGregor]

What does String(numericValue) === rank do here?

[meneogbemi42-bit]

String(numericValue) === rank acts as a crucial validation guard. It checks if the original rank string was perfectly converted into a number, with no extra characters, decimal points, or weird spacing hanging around.

[LonMcGregor]

Good explanation about the guard - I think it might be a bit unnecessary though, as you are converting to an integer immediately before you convert back to a string, so if there was a problem, it would show up there. However, it is good that you are considering these edge cases.

Great job simplifying the return value in the fractions task. Now that your return has a zero check, do you still need the if earlier in the code?

[meneogbemi42-bit]

please i just wanted to be sure of the code you are talking about so i chould correct it.

[LonMcGregor]

I think here you could probably remove the guard. You can also change your fractions function - now you have your zero checked in the return, do you still need the if part above it?

[meneogbemi42-bit]

if i remove {if (rank === "A") return 11;} passing an Ace (like "A♠") will now be treated as an invalid rank and will throw an error. and If you remove the line if (["J", "Q", "K"].includes(rank)) return 10;, face cards (Jacks, Queens, and Kings) will no longer be recognized as valid and will throw an error.