London | 26-ITP-May | Liridona Shehu | Sprint 3 | Implement and rewrite by shehu-dona · Pull Request #1474 · CodeYourFuture/Module-Structuring-and-Testing-Data

shehu-dona · 2026-07-06T20:14:48Z

Learners, PR Template

Self checklist

[ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[ x ] My changes meet the requirements of the task
[ x ] I have tested my changes
[ x ] My changes follow the style guide

Changelist

A PR with exercises using Jest

Luro91

I have a couple of comments

Luro91 · 2026-07-09T05:24:11Z

+  else if( angle > 180  && angle < 360){
+    return "Reflex angle";
+  }
+  else return "Invalid angle";


FYI: You don't need the else here as the code will only run if no other condition was true

Luro91 · 2026-07-09T05:24:41Z

+  if(  angle > 0 && angle < 90){
+    return "Acute angle";
+  }
+  else if  (angle === 90){
+    return  "Right angle";
+  }
+  else if ( angle > 90 && angle < 180){
+    return "Obtuse angle";
+  }
+  else if(angle === 180){
+    return "Straight angle";
+  }
+  else if( angle > 180  && angle < 360){


I see some white spaces in the conditions that are not needed. How can you ensure consistent formatting in your code?

I updated json file and added "editor.defaultFormatter": "esbenp.prettier-vscode"

Luro91 · 2026-07-09T05:26:21Z

+test(`should return "Invalid angle" when (180 < angle < 360)`, () => {
+  // Test various invalid angles, including boundary cases
+  expect(getAngleType(0)).toEqual("Invalid angle");
+  expect(getAngleType(360)).toEqual("Invalid angle");


You could add 2 test cases that are not boundary cases

Added more test cases that are not boundary cases.

Which test cases did you add? I do not see any new ones.

Luro91 · 2026-07-09T05:28:01Z

+// Special case: numerator is negative is a proper fraction
+test(`should return false when numerator is negative value`, () => {
+  expect(isProperFraction(-1, 2)).toEqual(false);
+});
+
+
+// Special case: denominator is negative is a proper fraction


The comments say is a prober fracteion but the function should return false. This is confusing

Improved the comment.

What did you change about the comment?

Luro91 · 2026-07-09T05:28:28Z

+});
+
+
+// Special case: negative numerator with smaller value then negative dominator is a proper fraction


The comments say is a prober fracteion but the function should return false. This is confusing

Luro91 · 2026-07-09T05:29:14Z

+  const validRanks = ["A", "2", "3", "4", "5", "6", "7", "8", "9", "10", "J", "Q", "K"];
+  const validSuits = ["♠", "♥", "♦", "♣"];
+
+  let isValidRank = validRanks.includes(rank);
+  let isValidSuit = validSuits.includes(suit);
+
+
+
+// Invalid  Card
+if( !isValidRank || !isValidSuit ){
+  throw new Error("Invalid Card")


Thats a nice way of checking if the input is valid. By expliciting stating all allowed values that code is easy to understand

Luro91 · 2026-07-09T05:30:11Z

+// test(`Should throw an error when given an invalid card`, () => {
+//   expect(() => getCardValue("1♠")).toThrow();
+//   expect(() => getCardValue("Z♦")).toThrow();
+//   expect(() => getCardValue("11♥")).toThrow();
+//   expect(() => getCardValue("")).toThrow();
+// });
+


Why is this code commented out?

Never used toThrow() function before so I used the example as a reference why I was typing but forgot to remove it at the end.I removed unnecessary comments.

shehu-dona · 2026-07-11T08:05:04Z

Hello @Luro91, I read your comments and and updated the work.

Luro91 · 2026-07-12T05:32:11Z

Hello @Luro91, I read your comments and and updated the work.

I don't see some of the changes you mentioned. Maybe they were not pushed?

shehu-dona · 2026-07-14T12:50:16Z

Hello @Luro91,
I updated the code. Accidentally I changed the wrong files and got confused while trying to revert the changes. However I made the changes again and pushed them to Github.

Luro91

Negative fractions still need correct handling.

My tip for verifying that your submission is pushed: Always check the files changes page of the PR and see if the changes and the commits show up in Github: https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/1474/changes

shehu-dona · 2026-07-15T20:14:08Z

Hello @Luro91
I updated the code again.

Luro91

Well done. The code is working correctly now .

shehu-dona · 2026-07-17T16:00:23Z

Thank you for reviewing my PR

dona-shehu added 22 commits June 16, 2026 23:35

capitalize function, str declaration

7fd7710

Declaration and scope

88d76b4

Function parameters

b6def45

Add return a * b

d06f9a3

Sum function fixed return

c15a48e

Function with no parameter fixed

66ddc97

Calculate BMI

b82f302

Capitalize function

491605b

Convert pence to pound function

b8a684c

Removed comments

095f72d

Add 2p example

0a4c587

Time format pad()

4aa639f

Fixed variable declaration for bodyMassIndex

892bb92

implement, 1-get-angle-type.

4bc146e

implement, 2-is-proper-fraction

4ccf833

Implement, 3-get-card-value

4b20e69

Add comments to tests

6f270d2

Update error message

0799ea5

Add tests in Jest syntax

956f635

Add test in Jest syntax

5cec9c4

Used array to validate rank & suit

1096cc2

Add test in Jest syntax

6caf04c

This comment has been minimized.

Sign in to view

shehu-dona added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 6, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026

shehu-dona added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 6, 2026

Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 9, 2026

Luro91 reviewed Jul 9, 2026

View reviewed changes

dona-shehu added 4 commits July 10, 2026 00:17

Added default formatter, and more test cases.

31e40fa

Removed last unnecessary else.

68ce473

Updated the comments.

bfe4374

Removed unnecessary comments.

188448b

shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 11, 2026

Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 12, 2026

dona-shehu added 3 commits July 14, 2026 13:37

Updated the comments

02ceb6d

Formatted the code

cc3d083

Formatted the code

8e6a64c

shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 14, 2026

shehu-dona mentioned this pull request Jul 14, 2026

London | Structuring and testing data | LIRIDONA_SHEHU shehu-dona/My-Coursework-Planner#27

Open

Luro91 reviewed Jul 15, 2026

View reviewed changes

Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js Outdated

Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2026

dona-shehu added 2 commits July 15, 2026 21:08

Updated isProperFraction.

638dbd4

Negative numerator and denominator

f7ae1c1

shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2026

Luro91 reviewed Jul 16, 2026

View reviewed changes

		});


		// Special case: negative numerator with smaller value then negative dominator is a proper fraction

Uh oh!

Uh oh!

Conversation

shehu-dona commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shehu-dona commented Jul 11, 2026

Uh oh!

Luro91 commented Jul 12, 2026

Uh oh!

shehu-dona commented Jul 14, 2026

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shehu-dona commented Jul 15, 2026

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

shehu-dona commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shehu-dona commented Jul 6, 2026 •

edited

Loading