London | 25 -ITP-May | Dagim Daniel | Sprint 3 | implement and rewrite-test with jest#1473
Open
Dagim-Daniel wants to merge 8 commits into
Open
Conversation
…-card-value add line 37 to 40 and also done with the rewrite tests with jest tasks.
…t of get-card-value add line 37 to 40 and also done with the rewrite tests with jest tasks." This reverts commit c822d53.
Dagim-Daniel
added
Needs Review
…-card-value adding line 37 to line 40 and i also completed the rewrite-test with jest section - i revert a commit so i work on it again and re- commit it( problem was the jest edited the jason file -version)
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
…fied get-card-value adding line 37 to line 40 and i also completed the rewrite-test with jest section - i revert a commit so i work on it again and re- commit it( problem was the jest edited the jason file -version)" This reverts commit 927466a.
Dagim-Daniel
added
the
Needs Review
LonMcGregor
reviewed
Jul 13, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on these tasks. The implementations are working, but could be improved a bit more if you follow my comments
| function getAngleType(angle) { | ||
| // TODO: Implement this function | ||
| if (angle>0 && angle<90) | ||
| { |
There was a problem hiding this comment.
Did you remember to format this code?
Author
There was a problem hiding this comment.
i didn't get you, LonMcGregor sorry
| // TODO: Implement this function | ||
| numerator = Math.abs(numerator); | ||
| denominator = Math.abs(denominator); | ||
| if (numerator<denominator) |
There was a problem hiding this comment.
Could this if condition be simplified?
Author
There was a problem hiding this comment.
return numerator < denominator
| } | ||
|
|
||
| const numvalue = Number(value); | ||
| if (numvalue >= 2 && numvalue <= 10) { |
There was a problem hiding this comment.
Does this if condition need to be here? (Hint: compare it to the earlier if conditions)
Author
There was a problem hiding this comment.
i guess so, because the other if condition was for throw error. with out this if condition it wouldn't give us the the numvalue within this scop
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
all tasks under sprint 3 - implement and rewrite-test with jest has been done