London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Coursework/sprint 2#1458
London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Coursework/sprint 2#1458russom-g wants to merge 22 commits into
Conversation
…t different stages.
…function needs fixing.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
russom-g
added
the
Needs Review
Liam310
added
Review in progress
| // The return value of pad when it is called for the first time is 00. this is because the value of num is 0 and the pad function adds a 0 to the front of the string until the num characters has at least 2 characters. | ||
|
|
There was a problem hiding this comment.
To be precise, what exactly is the return value of pad? I think you know what it is, but 00 doesn't quite exactly describe it
There was a problem hiding this comment.
Hi Liam. Thanks for reviewing my code.
The exact return value is 0 . It ads a single 0 instead of two 0s.
There was a problem hiding this comment.
Not quite - what data type is the return value of pad?
|
|
||
| // The return value of pad when it is called for the last time is 01. This is because the pad function adds a 0 to the front of the string if the characters of the string are less than 2. No newline at end of file |
Liam310
removed
the
Review in progress
Liam310
added
the
Reviewed
…d added in order to test case for 1:00am to work
…declaring a parameter updated.
| let card = " "; | ||
| if (card.includes ) |
There was a problem hiding this comment.
These changes are in the Sprint-3 folder and so should not be part of this PR. Please undo these changes on this branch 🙂
|
Hey @russom-g! Just highlighting that you do still have some outstanding comments left on here. There's not a lot of work to do and I'd be happy to mark as complete once they are sorted! |
…lue.js File removed.
|
@russom-g I can see you deleted one of the offending files from Also, you may not have seen but there are still two other unresolved comments asking about the data type of a specific value: |
This reverts commit 1861b94.
…ule-Structuring-and-Testing-Data into coursework/sprint-2
|
@Liam310 I shouldn't have done that. I have tried to do it from vs code id didn't work. Then I taught if I do it on github from my pull request and branch it wouldn't affect the main. I know reverted the commits which pushed the wrong file to the PR from my vs code remotely. This branch mixup and untangling it has been a big headache for me for a few days now. I am not sure if you have seen the reply to your two last comments about the data types. I did reply a few days ago. Are they not visible to you? |
|
@russom-g I'm afraid all I can see is this: 
So I can't see any reply from you (on either thread) 🤔 |
|
@Liam310 I am not quite sure what is causing this. |
2 participants
Learners, PR Template
Self checklist
Changelist
I manage to predict, find, interpret and fix the errors in programs. I debugged each files and corrected the programs. I implemented functions based on requirements. I interpreted programs using documentations.