[client-v2] Abstract transport layer#2893
Open
chernser wants to merge 6 commits into
Open
Conversation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
changed the title
|
TriageCategory: Summary What this impacts
Concerns
Required reviewer action
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e1018a7. Configure here.
| @Override | ||
| public int getStatusCode() { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Status code always zero
Medium Severity
TransportResponseImpl.getStatusCode() always returns 0. This prevents consumers from accurately checking the HTTP status code, which can lead to misinterpreting server responses.
Reviewed by Cursor Bugbot for commit e1018a7. Configure here.
|
|
||
| } catch (Exception e) { | ||
| HttpAPIClientHelper.closeQuietly(httpResponse); | ||
| ClientUtils.quiteClose(transportResp, LOG); |
There was a problem hiding this comment.
Plain HTTP 503 no retry
Medium Severity
After the transport refactor, query and insert retry loops no longer treat HTTP 503 as retryable on their own. A 503 is turned into a ServerException with unknown ClickHouse code, shouldRetry returns false, and the client fails instead of picking another node like before.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit e1018a7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates boundary between
ClientandHttpAPIClientHelper:TransportRequestandTransportResponseobjects to hold all related context in one placeThis PR also removed some code duplication to reduce query/insert method logic. In the future it can be abstracted further.
PR does not change request logic mach but organizes code in different way.
Checklist
Delete items not relevant to your PR: