Add StringAt to ColumnDecimal#526
Merged
Merged
Conversation
kavirajk
reviewed
Jun 29, 2026
| }; | ||
|
|
||
| std::vector<TestSample> samples = { | ||
| {18, 0, "0", "0"}, |
There was a problem hiding this comment.
any invalid string case? e.g: {18, 0, "invalid"} and expect an exception?
Contributor
Author
There was a problem hiding this comment.
This test checks that numeric values are correctly converted to strings. So input always should be good. There is a separate test that checks the parsing itself. This one for bad strings:
https://github.com/ClickHouse/clickhouse-cpp/blob/master/ut/columns_ut.cpp#L70
kavirajk
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ColumnDecimal::StringAt(size_t), which returns the human-readable decimal string representation of the value at indexi, with the decimal point inserted according to the column's scale.Solves #477