Reset keyToScope and lastScope in ScopeInfoBuilder.build() so a reused builder does not leak state#7
Merged
szuend merged 2 commits intoJul 8, 2026
Conversation
szuend
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScopeInfoBuilder.build()returns the accumulatedScopeInfoand resets the builder so it can be reused. It clears#scopes,#ranges, and#knownScopes, but leaves#keyToScopeand#lastScopepopulated, so state from a previous build leaks into the next one.If you reuse a builder across two
build()calls, astartRange({ scopeKey })in the second build resolvesoriginalScopefrom a key registered during the first build, linking the range to a scope that is not part of the current tree. Encoding that result then throwsUnknown OriginalScope for definition!. A freshly constructed builder produces no such link.lastScope()has the same leak: it returns a scope from the prior build after abuild()that opened none.Fix
Clear
#keyToScopeand reset#lastScopeinbuild(), alongside the existing resets.Test
Added a case in
builder.test.ts: registerkey: 0and build once, then in a second build resolvescopeKey: 0and assert the range'soriginalScopeisundefined(andlastScope()isnull). It fails before the change and passes after.