Complete packaged Playground PHPUnit runtime support#1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1843 and #1825, discovered while running WPCOM PHPUnit against a locally rebuilt PHP.wasm runtime and Sodium side module.
Backwards compatibility
The builder inputs are additive. Existing PHPUnit recipes retain their current defaults. The diagnostic change only converts previously false-positive successful runs containing
STAGE_FAILorSTAGE_DIEinto failures.How to test
npm ci.npm run build.npm run test:runtime-services.npx tsx tests/playground-cli-runner-bootstrap-ini.test.ts.npx tsx tests/phpunit-project-autoload.test.ts.npm run test:php-wasm-extension-manifests.AI assistance