test(desktop-lite): fix transient failures

[sjinks]

This pull request makes minor improvements to the desktop-lite test scripts. The main change is the addition of brief pauses after restarting services in checks.sh to help ensure that services have time to start before their status is checked.

Improvements to service checks:

• Added sleep 1 after restarting the tigervnc, openbox, and novnc services in checks.sh to reduce the chance of race conditions when checking service status.

Code cleanup:

• Removed a duplicate shebang line from the top of test.sh.

[Copilot]

Pull request overview

This pull request adjusts the desktop-lite feature’s test scripts to reduce transient CI failures by giving services a moment to come up after restarts, and cleans up a duplicate shebang.

Changes:

• Removed a duplicate #!/bin/bash line from features/test/desktop-lite/test.sh.
• Added brief waits after restarting tigervnc, openbox, and novnc in features/test/desktop-lite/checks.sh.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
features/test/desktop-lite/test.sh	Removes a duplicate shebang line at the top of the script.
features/test/desktop-lite/checks.sh	Adds post-restart delays for runit-managed services to reduce race conditions during status checks.

Comments suppressed due to low confidence (3)

features/test/desktop-lite/checks.sh:15

• Same as above: a fixed sleep 1 is both slower and less reliable than waiting (with a timeout) for sv status to report run:.

    sleep 1

features/test/desktop-lite/checks.sh:22

• Same as above: consider bounded polling (with timeout) for the service to become run: rather than a fixed sleep.

    sleep 1

features/test/desktop-lite/checks.sh:30

• For consistency with the other feature checks.sh scripts, use the >/dev/null redirect form here as well.

if hash netstat > /dev/null 2>&1; then

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.