chore: exclude example/dist from eslint#49
Merged
Conversation
The example web export contains a 2 MB minified bundle that the prettier rule takes many minutes to process, so a local yarn lint effectively never finishes when example/dist exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
yarn lintlocally never finishes whenexample/dist(the example app's web export) exists: the eslint glob picks up the 2 MB minified_expo/static/js/web/entry-*.jsbundle and theprettier/prettierrule grinds on it for 10+ minutes. CI is unaffected since it lints a clean checkout. This addsexample/dist/to the flat-config ignores next to the other generated output (lib/).Test Plan
example/distpresent locally,yarn lint:eslintused to hang for 10+ minutes; with this change it completes in ~7 s with no errors.