Use Unicode punctuation in emphasis flanking rules#12
Merged
Conversation
delimiter_run_flags classified neighbours with is_ascii_punctuation, so
delimiter runs bounded by Unicode punctuation on one side and ASCII
punctuation on the other (e.g. curly quote outside, brace inside:
"***{{x}}***") failed the left/right-flanking checks and rendered as
literal asterisks. Classify punctuation as ASCII punctuation or Unicode
general category P, matching the spec's definition.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(“***{{company_common_name}}***”)rendered as literal asterisks instead of<em><strong>…</strong></em>.We used
is_ascii_punctuation()and the fancy quotation isn't matched by that function.Classify a character as punctuation if it is ASCII punctuation or in the Unicode P general category (via the dependency-free
unicode-propertiescrate)One fable remark that seems interesting:
Should we bump the spect to 0.30?