Skip to content

feat: update vm resource messages#13216

Merged
ssongliu merged 1 commit into
dev-v2from
pr@dev-v2@fix_vm
Jul 8, 2026
Merged

feat: update vm resource messages#13216
ssongliu merged 1 commit into
dev-v2from
pr@dev-v2@fix_vm

Conversation

@ssongliu

@ssongliu ssongliu commented Jul 8, 2026

Copy link
Copy Markdown
Member

No description provided.

@ssongliu ssongliu merged commit 6a988ad into dev-v2 Jul 8, 2026
3 checks passed
@ssongliu ssongliu deleted the pr@dev-v2@fix_vm branch July 8, 2026 07:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3015c5983d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread core/go.mod
github.com/quic-go/quic-go v0.59.0 // indirect
github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
github.com/sagikazarmark/locafero v0.12.0 // indirect
github.com/shirou/gopsutil/v4 v4.26.5 // indirect

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep gopsutil from being tidied away

In the visible core module, rg finds no Go import of github.com/shirou/gopsutil/v4; the existing pattern for xpack-only deps is core/deps/keepdeps.go, whose comment says it keeps them from being pruned. Since go help mod tidy states that tidy “removes unused modules,” running tidy in a non-xpack checkout will drop this new requirement and its checksums, so any xpack code relying on gopsutil can later fail under a readonly module build or after a tidy. Please add the appropriate blank import to the keepdeps file, or remove this requirement if it is not actually needed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant