From 371836a39aeaea648220be63ac0891cfe7694af8 Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Thu, 2 Jul 2026 15:55:58 +0300 Subject: [PATCH] gh-88574: Skip a spurious blank line after a literal in imaplib (GH-152751) Some IMAP servers send an extra blank line after the data of a literal. imaplib mistook it for the response trailer and failed on the next command. Such a blank line is now skipped. (cherry picked from commit 53ff1a28ccfa69925c3c452cfc003970640fa65b) Co-authored-by: Serhiy Storchaka Co-authored-by: Claude Opus 4.8 (1M context) --- Lib/imaplib.py | 4 ++++ Lib/test/test_imaplib.py | 17 +++++++++++++++++ ...026-07-01-10-00-00.gh-issue-88574.Kz3wQm.rst | 2 ++ 3 files changed, 23 insertions(+) create mode 100644 Misc/NEWS.d/next/Library/2026-07-01-10-00-00.gh-issue-88574.Kz3wQm.rst diff --git a/Lib/imaplib.py b/Lib/imaplib.py index 182b5010f55a52..109d05c423f388 100644 --- a/Lib/imaplib.py +++ b/Lib/imaplib.py @@ -1152,6 +1152,10 @@ def _get_response(self): dat = self._get_line() + # Skip a blank line that some servers send after a literal. + if dat == b'': + dat = self._get_line() + self._append_untagged(typ, dat) # Bracketed response information? diff --git a/Lib/test/test_imaplib.py b/Lib/test/test_imaplib.py index 5e777155dbedbd..78f066e0a47eb9 100644 --- a/Lib/test/test_imaplib.py +++ b/Lib/test/test_imaplib.py @@ -673,6 +673,23 @@ def test_lsub(self): self.assertEqual(typ, 'OK') self.assertEqual(server.args, ['~/Mail/', '%']) + def test_extra_blank_line_after_literal(self): + # Some buggy servers send an extra blank line after the counted + # literal data. imaplib should skip it instead of failing. + class BlankLineHandler(SimpleIMAPHandler): + def cmd_FETCH(self, tag, args): + self._send(b'* 1 FETCH (BODY[HEADER] {13}\r\n') + self._send(b'Subject: test') # 13-byte literal + self._send(b'\r\n)\r\n') # stray blank line, then ')' + self._send_tagged(tag, 'OK', 'FETCH completed') + client, _ = self._setup(BlankLineHandler) + client.login('user', 'pass') + client.select() + typ, data = client.fetch('1', '(BODY[HEADER])') + self.assertEqual(typ, 'OK') + self.assertEqual(data, [(b'1 (BODY[HEADER] {13}', b'Subject: test'), + b')']) + def test_unselect(self): client, server = self._setup(SimpleIMAPHandler) client.login('user', 'pass') diff --git a/Misc/NEWS.d/next/Library/2026-07-01-10-00-00.gh-issue-88574.Kz3wQm.rst b/Misc/NEWS.d/next/Library/2026-07-01-10-00-00.gh-issue-88574.Kz3wQm.rst new file mode 100644 index 00000000000000..8d95bbbb5a15e4 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2026-07-01-10-00-00.gh-issue-88574.Kz3wQm.rst @@ -0,0 +1,2 @@ +:mod:`imaplib` no longer fails when a server sends a spurious blank line +after the counted data of a literal. Such a blank line is now skipped.