From 4cdc60001aea6ae769f250a9a230f56fbb15f3f6 Mon Sep 17 00:00:00 2001 From: Kaleb Luedtke Date: Tue, 7 Jul 2026 11:50:07 -0500 Subject: [PATCH 1/4] Update Readme for E2E tests --- src/AppInstallerCLIE2ETests/README.md | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/AppInstallerCLIE2ETests/README.md b/src/AppInstallerCLIE2ETests/README.md index a4d5467440..7ad7946f41 100644 --- a/src/AppInstallerCLIE2ETests/README.md +++ b/src/AppInstallerCLIE2ETests/README.md @@ -20,9 +20,14 @@ If your tests uses the test source see the [LocalhostWebServer](#LocalhostWebSer | MsixTestInstallerPath | The MSIX (or APPX) Installer executable under test. | | ExeTestInstallerPath |The Exe Installer executable under test. | | MsiTestInstallerPath | The MSI Installer executable under test. | +| MsiTestInstallerV2Path | The v2 MSI Installer executable under test. | +| FontTestPath | The test font file used by font package scenarios. | | PackageCertificatePath | Signing Certificate Path used to certify test index source package | | PowerShellModulePath | Path to the PowerShell module manifest file under test | -| PowerShellModulePath | The local server cert file | +| LocalServerCertPath | The local server cert file. | +| InprocTestbedPath | Path to the ComInprocTestbed executable used by in-proc COM tests. | +| InprocTestbedUseTestPackage | Bool to indicate whether in-proc COM tests should target the test package. | +| ForcedExperimentalFeatures | Pipe-separated list of experimental features to force-enable during test setup. | | SkipTestSource | I solemnly swear the test won't use the local test source or the source is already set up. | #### Example of Test.runsettings with completed parameters: @@ -38,8 +43,15 @@ Assuming you clone winget-cli in c:\dev, the localhost web server is running in + + + + + + + From 93f0bc7cc051470e876ce96d4c5bf0fe21457e7c Mon Sep 17 00:00:00 2001 From: Kaleb Luedtke Date: Tue, 7 Jul 2026 11:56:12 -0500 Subject: [PATCH 2/4] Add a short copilot instruction --- .../instructions/e2e-test-setup-parameters.instructions.md | 7 +++++++ .gitignore | 3 +++ 2 files changed, 10 insertions(+) create mode 100644 .github/instructions/e2e-test-setup-parameters.instructions.md diff --git a/.github/instructions/e2e-test-setup-parameters.instructions.md b/.github/instructions/e2e-test-setup-parameters.instructions.md new file mode 100644 index 0000000000..3a269f9224 --- /dev/null +++ b/.github/instructions/e2e-test-setup-parameters.instructions.md @@ -0,0 +1,7 @@ +--- +applyTo: "src/AppInstallerCLIE2ETests/Helpers/TestSetup.cs" +--- + +# E2E test setup parameter documentation + +When adding a new test parameter in `src/AppInstallerCLIE2ETests/Helpers/TestSetup.cs`, also update `src/AppInstallerCLIE2ETests/README.md` to document that parameter. diff --git a/.gitignore b/.gitignore index de37448c2f..8fe74c16ae 100644 --- a/.gitignore +++ b/.gitignore @@ -283,6 +283,9 @@ node_modules/ # Visual Studio LightSwitch build output **/*.HTMLClient/GeneratedArtifacts **/*.DesktopClient/GeneratedArtifacts + +# Local E2E test settings (developer-specific) +Test.local.runsettings **/*.DesktopClient/ModelManifest.xml **/*.Server/GeneratedArtifacts **/*.Server/ModelManifest.xml From 951add2f94754f05fd505cfdf28dfa7390aebb81 Mon Sep 17 00:00:00 2001 From: Kaleb Luedtke Date: Tue, 7 Jul 2026 12:00:03 -0500 Subject: [PATCH 3/4] Gitignore local runsettings --- .gitignore | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 8fe74c16ae..888f81ee06 100644 --- a/.gitignore +++ b/.gitignore @@ -283,14 +283,15 @@ node_modules/ # Visual Studio LightSwitch build output **/*.HTMLClient/GeneratedArtifacts **/*.DesktopClient/GeneratedArtifacts - -# Local E2E test settings (developer-specific) -Test.local.runsettings **/*.DesktopClient/ModelManifest.xml **/*.Server/GeneratedArtifacts **/*.Server/ModelManifest.xml _Pvt_Extensions +# Local E2E test settings (developer-specific), keep the example one tracked +*.runsettings +!src/AppInstallerCLIE2ETests/Test.runsettings + # Paket dependency manager .paket/paket.exe paket-files/ From 9cf0e2ec989c7876c4339af653bba7c3b23afadf Mon Sep 17 00:00:00 2001 From: Kaleb Luedtke Date: Tue, 7 Jul 2026 12:02:24 -0500 Subject: [PATCH 4/4] Update tracked runsettings file --- .../e2e-test-setup-parameters.instructions.md | 5 ++++- src/AppInstallerCLIE2ETests/Test.runsettings | 12 ++++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/.github/instructions/e2e-test-setup-parameters.instructions.md b/.github/instructions/e2e-test-setup-parameters.instructions.md index 3a269f9224..d15bb4f060 100644 --- a/.github/instructions/e2e-test-setup-parameters.instructions.md +++ b/.github/instructions/e2e-test-setup-parameters.instructions.md @@ -4,4 +4,7 @@ applyTo: "src/AppInstallerCLIE2ETests/Helpers/TestSetup.cs" # E2E test setup parameter documentation -When adding a new test parameter in `src/AppInstallerCLIE2ETests/Helpers/TestSetup.cs`, also update `src/AppInstallerCLIE2ETests/README.md` to document that parameter. +When adding a new test parameter in `src/AppInstallerCLIE2ETests/Helpers/TestSetup.cs`, also update: + +- `src/AppInstallerCLIE2ETests/README.md` to document that parameter. +- `src/AppInstallerCLIE2ETests/Test.runsettings` to keep default run parameters and parameter names in sync. diff --git a/src/AppInstallerCLIE2ETests/Test.runsettings b/src/AppInstallerCLIE2ETests/Test.runsettings index bbdc7f7163..445abf9128 100644 --- a/src/AppInstallerCLIE2ETests/Test.runsettings +++ b/src/AppInstallerCLIE2ETests/Test.runsettings @@ -20,7 +20,11 @@ ExeTestInstallerPath: The Exe Installer executable under test. PackageCertificatePath: Signing Certificate Path used to certify Index Source Package. PowerShellModulePath: Path to the PowerShell module manifest file under test. - LocalServerCertPathParameter: The cert used for the local server. + LocalServerCertPath: The cert used for the local server. + MsiTestInstallerV2Path: The v2 MSI Installer executable under test. + InprocTestbedPath: Path to the ComInprocTestbed executable used by in-proc COM tests. + InprocTestbedUseTestPackage: Bool to indicate whether in-proc COM tests should target the test package. + ForcedExperimentalFeatures: Pipe-separated list of experimental features to force-enable during test setup. SkipTestSource: I solemnly swear the test won't use the local test source or the source is already set up. --> @@ -35,9 +39,13 @@ + - + + + +