From d7ecafd85823030b65df8ffb08749bfad3f6b952 Mon Sep 17 00:00:00 2001 From: Rakesh Falke Date: Wed, 8 Apr 2026 16:12:34 +0530 Subject: [PATCH 1/4] Settings API: Add ID attributes to section title headings. --- src/wp-admin/includes/template.php | 2 +- src/wp-admin/options-discussion.php | 2 +- src/wp-admin/options-media.php | 6 +++--- src/wp-admin/options-permalink.php | 4 ++-- src/wp-admin/options-writing.php | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/wp-admin/includes/template.php b/src/wp-admin/includes/template.php index 6680bca89691a..5f283761e2880 100644 --- a/src/wp-admin/includes/template.php +++ b/src/wp-admin/includes/template.php @@ -1780,7 +1780,7 @@ function do_settings_sections( $page ) { } if ( $section['title'] ) { - echo "

{$section['title']}

\n"; + echo '

' . $section['title'] . "

\n"; } if ( $section['callback'] ) { diff --git a/src/wp-admin/options-discussion.php b/src/wp-admin/options-discussion.php index 0c350475fe176..3fe231286831e 100644 --- a/src/wp-admin/options-discussion.php +++ b/src/wp-admin/options-discussion.php @@ -211,7 +211,7 @@ -

+

diff --git a/src/wp-admin/options-media.php b/src/wp-admin/options-media.php index 81ebc9223f543..973fc063637de 100644 --- a/src/wp-admin/options-media.php +++ b/src/wp-admin/options-media.php @@ -52,7 +52,7 @@
-

+

@@ -104,14 +104,14 @@ */ if ( isset( $GLOBALS['wp_settings']['media']['embeds'] ) ) : ?> -

+

-

+

-

+

-

+

+

-

+

From 78f84170a15da6925c111d3bf6eb17a30f882113 Mon Sep 17 00:00:00 2001 From: Joe Dolson Date: Tue, 7 Jul 2026 15:26:16 -0500 Subject: [PATCH 2/4] Add prefix to section ID to reduce conflicts. --- src/wp-admin/includes/template.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/includes/template.php b/src/wp-admin/includes/template.php index 5f283761e2880..4021bfea5baff 100644 --- a/src/wp-admin/includes/template.php +++ b/src/wp-admin/includes/template.php @@ -1780,7 +1780,7 @@ function do_settings_sections( $page ) { } if ( $section['title'] ) { - echo '

' . $section['title'] . "

\n"; + echo '

' . $section['title'] . "

\n"; } if ( $section['callback'] ) { From d02b98b4cda1a1cea21ef681bafdeb61e8727d68 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Thu, 9 Jul 2026 15:44:17 +0200 Subject: [PATCH 3/4] Use wp_unique_id. --- src/wp-admin/includes/template.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wp-admin/includes/template.php b/src/wp-admin/includes/template.php index 4021bfea5baff..336e8625f5f9f 100644 --- a/src/wp-admin/includes/template.php +++ b/src/wp-admin/includes/template.php @@ -1780,7 +1780,8 @@ function do_settings_sections( $page ) { } if ( $section['title'] ) { - echo '

' . $section['title'] . "

\n"; + $unique_id = wp_unique_id( 'wp-settings-section-' . $section['id'] . '-' ); + echo '

' . $section['title'] . "

\n"; } if ( $section['callback'] ) { From 5144d56896c31453f62dc604f2c5bff75bfb7595 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Thu, 9 Jul 2026 15:51:34 +0200 Subject: [PATCH 4/4] Add prefix to core setting sections. --- src/wp-admin/options-discussion.php | 2 +- src/wp-admin/options-media.php | 6 +++--- src/wp-admin/options-permalink.php | 4 ++-- src/wp-admin/options-writing.php | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/wp-admin/options-discussion.php b/src/wp-admin/options-discussion.php index 3fe231286831e..f8e4d5040f4e7 100644 --- a/src/wp-admin/options-discussion.php +++ b/src/wp-admin/options-discussion.php @@ -211,7 +211,7 @@ -

+

diff --git a/src/wp-admin/options-media.php b/src/wp-admin/options-media.php index 973fc063637de..d7decddf01537 100644 --- a/src/wp-admin/options-media.php +++ b/src/wp-admin/options-media.php @@ -52,7 +52,7 @@ -

+

@@ -104,14 +104,14 @@ */ if ( isset( $GLOBALS['wp_settings']['media']['embeds'] ) ) : ?> -

+

-

+

-

+

-

+

+

-

+