From 04eb8d1e4386d6229065dbfc920c7d355e0b0507 Mon Sep 17 00:00:00 2001 From: YohYamasaki Date: Wed, 1 Jul 2026 13:48:37 +0900 Subject: [PATCH 1/6] Test all workspace crates in CI --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 573c1dff91..b0d88b8d08 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -59,7 +59,7 @@ jobs: env: # `--cfg=web_sys_unstable_apis` mirrors the `[build]` section of `.cargo/config.toml` RUSTFLAGS: "-Dwarnings --cfg=web_sys_unstable_apis" - run: mold -run cargo test --all-features + run: mold -run cargo test --workspace --all-features # Rust format check on GitHub runner rust-fmt: From 87254c843eccd26b09e122acb60a315077713f76 Mon Sep 17 00:00:00 2001 From: YohYamasaki Date: Wed, 1 Jul 2026 14:14:47 +0900 Subject: [PATCH 2/6] Remove unused import --- node-graph/graphene-cli/src/main.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/node-graph/graphene-cli/src/main.rs b/node-graph/graphene-cli/src/main.rs index 673b0c3aa2..765c96f6c0 100644 --- a/node-graph/graphene-cli/src/main.rs +++ b/node-graph/graphene-cli/src/main.rs @@ -7,7 +7,6 @@ use document_format::{GddV1, GddV1Layout}; use fern::colors::{Color, ColoredLevelConfig}; use futures::executor::block_on; use graph_craft::application_io::EditorPreferences; -use graph_craft::application_io::resource::ResourceRegistry; use graph_craft::application_io::{PlatformApplicationIo, PlatformEditorApi}; use graph_craft::document::*; use graph_craft::graphene_compiler::Compiler; From 8932e1bd78493526bf6ae951ff0b2f0b6c70c0ed Mon Sep 17 00:00:00 2001 From: YohYamasaki Date: Wed, 1 Jul 2026 15:26:38 +0900 Subject: [PATCH 3/6] Skip desktop license embedding in CI tests --- .github/workflows/check.yml | 2 +- desktop/Cargo.toml | 5 +++++ desktop/src/app.rs | 26 ++++++++++++++++++-------- 3 files changed, 24 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index b0d88b8d08..1b68be3c92 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -58,7 +58,7 @@ jobs: - name: 🧪 Run Rust tests env: # `--cfg=web_sys_unstable_apis` mirrors the `[build]` section of `.cargo/config.toml` - RUSTFLAGS: "-Dwarnings --cfg=web_sys_unstable_apis" + RUSTFLAGS: "-Dwarnings --cfg=web_sys_unstable_apis --cfg=skip_desktop_license_embed" run: mold -run cargo test --workspace --all-features # Rust format check on GitHub runner diff --git a/desktop/Cargo.toml b/desktop/Cargo.toml index d7f3112b87..29e045556a 100644 --- a/desktop/Cargo.toml +++ b/desktop/Cargo.toml @@ -74,3 +74,8 @@ objc2 = { version = "0.6.1", default-features = false } objc2-foundation = { version = "0.3.2", default-features = false } objc2-app-kit = { version = "0.3.2", default-features = false } muda = { git = "https://github.com/timon-schelling/muda.git", rev = "e5bc28bbd6781b18afbfc237981f9ef47eddf863", default-features = false } + +[lints.rust] +unexpected_cfgs = { level = "warn", check-cfg = [ + 'cfg(skip_desktop_license_embed)', +] } diff --git a/desktop/src/app.rs b/desktop/src/app.rs index 1c0841d7c7..6b49e2204f 100644 --- a/desktop/src/app.rs +++ b/desktop/src/app.rs @@ -1,7 +1,6 @@ use rand::Rng; use rfd::AsyncFileDialog; use std::fs; -use std::io::Read; use std::path::PathBuf; use std::sync::Arc; use std::sync::atomic::{AtomicBool, Ordering}; @@ -399,16 +398,27 @@ impl App { self.exit(Some(ExitReason::Restart)); } DesktopFrontendMessage::LoadThirdPartyLicenses => { - let compressed = include_bytes!(concat!(env!("CARGO_MANIFEST_DIR"), "/third-party-licenses.txt.xz")); - let mut reader = lzma_rust2::XzReader::new(compressed.as_slice(), false); - let mut text = String::new(); - if let Err(e) = reader.read_to_string(&mut text) { - tracing::error!("Failed to decompress third-party licenses: {e}"); + #[cfg(skip_desktop_license_embed)] + { + tracing::info!("Third-party licenses are not embedded in test builds"); return; } - let message = DesktopWrapperMessage::LoadThirdPartyLicenses { text }; - responses.push(message); + #[cfg(not(skip_desktop_license_embed))] + { + use std::io::Read; + + let compressed = include_bytes!(concat!(env!("CARGO_MANIFEST_DIR"), "/third-party-licenses.txt.xz")); + let mut reader = lzma_rust2::XzReader::new(compressed.as_slice(), false); + let mut text = String::new(); + if let Err(e) = reader.read_to_string(&mut text) { + tracing::error!("Failed to decompress third-party licenses: {e}"); + return; + } + + let message = DesktopWrapperMessage::LoadThirdPartyLicenses { text }; + responses.push(message); + } } } } From a256389a2e2283ad72af65bd38184d1893ecb776 Mon Sep 17 00:00:00 2001 From: YohYamasaki Date: Wed, 1 Jul 2026 16:57:49 +0900 Subject: [PATCH 4/6] Avoid license embedding on doctest --- .github/workflows/check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 1b68be3c92..291a59c1b8 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -59,6 +59,7 @@ jobs: env: # `--cfg=web_sys_unstable_apis` mirrors the `[build]` section of `.cargo/config.toml` RUSTFLAGS: "-Dwarnings --cfg=web_sys_unstable_apis --cfg=skip_desktop_license_embed" + RUSTDOCFLAGS: "--cfg=skip_desktop_license_embed" run: mold -run cargo test --workspace --all-features # Rust format check on GitHub runner From 44b280ee988d52b526e04e5680186b06ad892c6c Mon Sep 17 00:00:00 2001 From: YohYamasaki Date: Wed, 1 Jul 2026 19:00:26 +0900 Subject: [PATCH 5/6] Temp commit: Check ci time without cache --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 291a59c1b8..5a8cd744e1 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -37,7 +37,7 @@ jobs: if: needs.skip-check.outputs.skip != 'true' runs-on: [self-hosted, target/native] env: - RUSTC_WRAPPER: /usr/bin/sccache + RUSTC_WRAPPER: "" CARGO_INCREMENTAL: 0 SCCACHE_DIR: /var/lib/github-actions/.cache steps: From e1cba1736fd91e54d252da1b6f44be8ca38f9f9d Mon Sep 17 00:00:00 2001 From: YohYamasaki Date: Wed, 1 Jul 2026 19:21:38 +0900 Subject: [PATCH 6/6] Revert "Temp commit: Check ci time without cache" This reverts commit 44b280ee988d52b526e04e5680186b06ad892c6c. --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 5a8cd744e1..291a59c1b8 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -37,7 +37,7 @@ jobs: if: needs.skip-check.outputs.skip != 'true' runs-on: [self-hosted, target/native] env: - RUSTC_WRAPPER: "" + RUSTC_WRAPPER: /usr/bin/sccache CARGO_INCREMENTAL: 0 SCCACHE_DIR: /var/lib/github-actions/.cache steps: